* [Qemu-devel] [PATCH] configure: check for pixman-1 version
@ 2014-09-15 1:53 Hu Tao
2014-09-15 2:23 ` Peter Maydell
0 siblings, 1 reply; 5+ messages in thread
From: Hu Tao @ 2014-09-15 1:53 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
commit a93a3af9 introduces use of PIXMAN_TYPE_RGBA, but it's only available
in pixman >= 0.21.8. If pixman doesn't meet the version requirement, qemu
will fail to build with following message:
/home/hutao/qemu/ui/qemu-pixman.c: In function ‘qemu_pixelformat_from_pixman’:
/home/hutao/qemu/ui/qemu-pixman.c:42: error: ‘PIXMAN_TYPE_RGBA’ undeclared (first use in this function)
/home/hutao/qemu/ui/qemu-pixman.c:42: error: (Each undeclared identifier is reported only once
/home/hutao/qemu/ui/qemu-pixman.c:42: error: for each function it appears in.)
This patch fixes the problem by checking the pixman version.
Reported-by: Andreas Gustafsson <gson@gson.org>
Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
---
configure | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 961bf6f..1a9daa5 100755
--- a/configure
+++ b/configure
@@ -2737,7 +2737,7 @@ fi
if test "$pixman" = ""; then
if test "$want_tools" = "no" -a "$softmmu" = "no"; then
pixman="none"
- elif $pkg_config pixman-1 > /dev/null 2>&1; then
+ elif $pkg_config --atleast-version=0.21.8 pixman-1 > /dev/null 2>&1; then
pixman="system"
else
pixman="internal"
@@ -2753,11 +2753,12 @@ if test "$pixman" = "none"; then
pixman_cflags=
pixman_libs=
elif test "$pixman" = "system"; then
+ # pixman version has been checked above
pixman_cflags=`$pkg_config --cflags pixman-1`
pixman_libs=`$pkg_config --libs pixman-1`
else
if test ! -d ${source_path}/pixman/pixman; then
- error_exit "pixman not present. Your options:" \
+ error_exit "pixman >= 0.21.8 not present. Your options:" \
" (1) Preferred: Install the pixman devel package (any recent" \
" distro should have packages as Xorg needs pixman too)." \
" (2) Fetch the pixman submodule, using:" \
--
1.8.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] configure: check for pixman-1 version
2014-09-15 1:53 [Qemu-devel] [PATCH] configure: check for pixman-1 version Hu Tao
@ 2014-09-15 2:23 ` Peter Maydell
2014-09-15 2:41 ` Hu Tao
0 siblings, 1 reply; 5+ messages in thread
From: Peter Maydell @ 2014-09-15 2:23 UTC (permalink / raw)
To: Hu Tao; +Cc: QEMU Developers, Gerd Hoffmann
On 14 September 2014 18:53, Hu Tao <hutao@cn.fujitsu.com> wrote:
> commit a93a3af9 introduces use of PIXMAN_TYPE_RGBA, but it's only available
> in pixman >= 0.21.8. If pixman doesn't meet the version requirement, qemu
> will fail to build with following message:
>
> /home/hutao/qemu/ui/qemu-pixman.c: In function ‘qemu_pixelformat_from_pixman’:
> /home/hutao/qemu/ui/qemu-pixman.c:42: error: ‘PIXMAN_TYPE_RGBA’ undeclared (first use in this function)
> /home/hutao/qemu/ui/qemu-pixman.c:42: error: (Each undeclared identifier is reported only once
> /home/hutao/qemu/ui/qemu-pixman.c:42: error: for each function it appears in.)
>
> This patch fixes the problem by checking the pixman version.
This alone is not sufficient, because the version of pixman
we have in our submodule is only 0.18.4. We also need to
bump that if we want to use newer versions (and to note
the increased dependency in our release notes next time
round).
thanks
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: check for pixman-1 version
2014-09-15 2:23 ` Peter Maydell
@ 2014-09-15 2:41 ` Hu Tao
2014-09-15 3:19 ` Hu Tao
0 siblings, 1 reply; 5+ messages in thread
From: Hu Tao @ 2014-09-15 2:41 UTC (permalink / raw)
To: Peter Maydell; +Cc: QEMU Developers, Gerd Hoffmann
On Sun, Sep 14, 2014 at 07:23:20PM -0700, Peter Maydell wrote:
> On 14 September 2014 18:53, Hu Tao <hutao@cn.fujitsu.com> wrote:
> > commit a93a3af9 introduces use of PIXMAN_TYPE_RGBA, but it's only available
> > in pixman >= 0.21.8. If pixman doesn't meet the version requirement, qemu
> > will fail to build with following message:
> >
> > /home/hutao/qemu/ui/qemu-pixman.c: In function ‘qemu_pixelformat_from_pixman’:
> > /home/hutao/qemu/ui/qemu-pixman.c:42: error: ‘PIXMAN_TYPE_RGBA’ undeclared (first use in this function)
> > /home/hutao/qemu/ui/qemu-pixman.c:42: error: (Each undeclared identifier is reported only once
> > /home/hutao/qemu/ui/qemu-pixman.c:42: error: for each function it appears in.)
> >
> > This patch fixes the problem by checking the pixman version.
>
> This alone is not sufficient, because the version of pixman
> we have in our submodule is only 0.18.4. We also need to
> bump that if we want to use newer versions (and to note
> the increased dependency in our release notes next time
> round).
Oh. I didn't noticed that. Should we just bump to the latest stable
pixman? or choose a best version?
Regards,
Hu
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: check for pixman-1 version
2014-09-15 2:41 ` Hu Tao
@ 2014-09-15 3:19 ` Hu Tao
2014-09-15 12:22 ` Paolo Bonzini
0 siblings, 1 reply; 5+ messages in thread
From: Hu Tao @ 2014-09-15 3:19 UTC (permalink / raw)
To: Peter Maydell; +Cc: Paolo Bonzini, QEMU Developers, Gerd Hoffmann
CCed Paolo
On Mon, Sep 15, 2014 at 10:41:09AM +0800, Hu Tao wrote:
> On Sun, Sep 14, 2014 at 07:23:20PM -0700, Peter Maydell wrote:
> > On 14 September 2014 18:53, Hu Tao <hutao@cn.fujitsu.com> wrote:
> > > commit a93a3af9 introduces use of PIXMAN_TYPE_RGBA, but it's only available
> > > in pixman >= 0.21.8. If pixman doesn't meet the version requirement, qemu
> > > will fail to build with following message:
> > >
> > > /home/hutao/qemu/ui/qemu-pixman.c: In function ‘qemu_pixelformat_from_pixman’:
> > > /home/hutao/qemu/ui/qemu-pixman.c:42: error: ‘PIXMAN_TYPE_RGBA’ undeclared (first use in this function)
> > > /home/hutao/qemu/ui/qemu-pixman.c:42: error: (Each undeclared identifier is reported only once
> > > /home/hutao/qemu/ui/qemu-pixman.c:42: error: for each function it appears in.)
> > >
> > > This patch fixes the problem by checking the pixman version.
> >
> > This alone is not sufficient, because the version of pixman
> > we have in our submodule is only 0.18.4. We also need to
> > bump that if we want to use newer versions (and to note
> > the increased dependency in our release notes next time
> > round).
>
> Oh. I didn't noticed that. Should we just bump to the latest stable
> pixman? or choose a best version?
commit f27b2e1d bumped to pixman-0.28.2, but reverted later by 7b1b5d19 (mistakenly?)
Regards,
Hu
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-09-15 12:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-15 1:53 [Qemu-devel] [PATCH] configure: check for pixman-1 version Hu Tao
2014-09-15 2:23 ` Peter Maydell
2014-09-15 2:41 ` Hu Tao
2014-09-15 3:19 ` Hu Tao
2014-09-15 12:22 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).