From: Michael Tokarev <mjt@tls.msk.ru>
To: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] arch_init: Setting QEMU_ARCH enum straight
Date: Mon, 15 Sep 2014 17:03:40 +0400 [thread overview]
Message-ID: <5416E3AC.1070701@msgid.tls.msk.ru> (raw)
In-Reply-To: <1410179457-19737-1-git-send-email-kbastian@mail.uni-paderborn.de>
08.09.2014 16:30, Bastian Koppelmann wrote:
> Every QEMU_ARCH is now hexadecimal instead of a mixture of decimal and hexadecimal.
I'm not sure it is worth the trouble really. For readability, the best in this case
(in my opinion anyway) is to use (1<<n) notation (with consecutive n), so it becomes
really obvious that these are distinct bits. Besides, -0x01 (fo ARCH_ALL) does look
a bit weird :)
Thanks,
/mjt
prev parent reply other threads:[~2014-09-15 13:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 12:30 [Qemu-devel] [PATCH] arch_init: Setting QEMU_ARCH enum straight Bastian Koppelmann
2014-09-15 13:03 ` Michael Tokarev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5416E3AC.1070701@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=kbastian@mail.uni-paderborn.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).