From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTYLJ-0005IM-Ir for qemu-devel@nongnu.org; Mon, 15 Sep 2014 11:37:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTYLD-0001zd-C8 for qemu-devel@nongnu.org; Mon, 15 Sep 2014 11:37:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23753) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTYLD-0001zY-4l for qemu-devel@nongnu.org; Mon, 15 Sep 2014 11:37:23 -0400 Message-ID: <54170797.4090309@redhat.com> Date: Mon, 15 Sep 2014 17:36:55 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <6adbf3b6e6c1eb09e50e3041c0bd0747fc6f3d87.1410682231.git.alistair23@gmail.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Patch v1 4/8] target_arm: Remove memory region init from armv7m_init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , Alistair Francis Cc: Peter Maydell , Martin Galvan , "qemu-devel@nongnu.org Developers" , Konstanty Bialkowski Il 15/09/2014 17:20, Peter Crosthwaite ha scritto: >> > + /* Flash programming is done via the SCU, so pretend it is ROM. */ >> > + memory_region_init_ram(flash, NULL, "armv7m.flash", flash_size); > You can give this a better name, such as "stellaris.flash" now that we > are not in armv7m anymore. > > Paolo, do you have any advice as to whether we should attempt to > parent this MR to the machine or something or just stay NULL > (considering we are in non-qdevified code?). The machine is the default owner anyway. Paolo