From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42214) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTYtQ-0007Vh-TK for qemu-devel@nongnu.org; Mon, 15 Sep 2014 12:12:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTYtG-0005PL-Sn for qemu-devel@nongnu.org; Mon, 15 Sep 2014 12:12:44 -0400 Received: from mail-pd0-x22e.google.com ([2607:f8b0:400e:c02::22e]:35286) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTYtG-0005P4-LJ for qemu-devel@nongnu.org; Mon, 15 Sep 2014 12:12:34 -0400 Received: by mail-pd0-f174.google.com with SMTP id v10so6467956pde.19 for ; Mon, 15 Sep 2014 09:12:29 -0700 (PDT) Sender: Richard Henderson Message-ID: <54170FE6.1060507@twiddle.net> Date: Mon, 15 Sep 2014 09:12:22 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1410723938-18007-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1410723938-18007-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/5] target-mips: Fix unused-function warnings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: Aurelien Jarno , patches@linaro.org On 09/14/2014 12:45 PM, Peter Maydell wrote: > These patches fix a number of warnings in target-mips code that > clang produces; notably, clang will complain about unused > 'static inline' functions in .c files where gcc does not. > Some are genuinely totally unused; a few are unused only in some > configs and so we add ifdef guards. > > (I've actually had these lying around for a while but forgot to > send them.) > > Peter Maydell (5): > target-mips: Remove unused gen_load_ACX, gen_store_ACX and cpu_ACX > target-mips/translate.c: Add ifdef guard around check_mips64() > target-mips/dsp_helper.c: Add ifdef guards around various functions > target-mips/dsp_helper.c: Remove unused function get_DSPControl_24() > target-mips/op_helper.c: Remove unused do_lbu() function > > target-mips/dsp_helper.c | 26 ++++++++++++++++---------- > target-mips/op_helper.c | 1 - > target-mips/translate.c | 22 +++------------------- > 3 files changed, 19 insertions(+), 30 deletions(-) > Reviewed-by: Richard Henderson r~