From: Li Liu <john.liuli@huawei.com>
To: Michael Tokarev <mjt@tls.msk.ru>, armbru@redhat.com
Cc: qemu-trivial@nongnu.org, kraxel@redhat.com,
qemu-devel@nongnu.org, peter.huangpeng@huawei.com
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] qemu-char: fix terminal crash when using "-monitor stdio -nographic"
Date: Tue, 16 Sep 2014 09:40:28 +0800 [thread overview]
Message-ID: <5417950C.1040004@huawei.com> (raw)
In-Reply-To: <5416E22B.9060002@msgid.tls.msk.ru>
On 2014/9/15 20:57, Michael Tokarev wrote:
> 15.09.2014 16:50, Michael Tokarev пишет:
>> 09.09.2014 15:19, john.liuli wrote:
>>> From: Li Liu <john.liuli@huawei.com>
>>>
>>> Eeay to reproduce, just try "qemu -monitor stdio -nographic"
>>> and type "quit", then the terminal will be crashed.
>>>
>>> There are two pathes try to call tcgetattr of stdio in vl.c:
>>
>> This looks reasonable. Except of one thing -- how about renaming
>> stdio_is_ready to stdio_in_use? (I can do that when applying, no
>> need to resend anythnig). Because, well, stdio_is_ready is not
>> obvious at all, at least to me... :)
>
> And oh, the commit comment -- it is not 'terminal crash', it is
> 'terminal misbehavor' or something like that. Terminal does not
> crash, it just does not have proper settings after qemu exits.
>
> /mjt
>
Thanks four your comments! Can you help do this when applying
incidentally? Or I will resend it again?
Best Regards,
Li.
> .
>
next prev parent reply other threads:[~2014-09-16 1:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 11:19 [Qemu-devel] [PATCH v2] qemu-char: fix terminal crash when using "-monitor stdio -nographic" john.liuli
2014-09-15 12:50 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-09-15 12:57 ` Michael Tokarev
2014-09-15 13:29 ` Gerd Hoffmann
2014-09-15 13:33 ` Markus Armbruster
2014-09-16 1:40 ` Li Liu [this message]
2014-09-16 4:20 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5417950C.1040004@huawei.com \
--to=john.liuli@huawei.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).