From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50201)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XTnuG-0005hK-LE
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 04:14:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XTnuA-0008WB-Bv
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 04:14:36 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42608)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XTnuA-0008Vt-5E
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 04:14:30 -0400
Message-ID: <5417F156.3020408@redhat.com>
Date: Tue, 16 Sep 2014 10:14:14 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20140915111740.2776.38029.stgit@PASHA-ISP>
	<5417458D.5090508@twiddle.net>
In-Reply-To: <5417458D.5090508@twiddle.net>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] target-i386: update fp status fix
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>, qemu-devel@nongnu.org
Cc: zealot351@gmail.com, maria.klimushenkova@ispras.ru, batuzovk@ispras.ru

Il 15/09/2014 22:01, Richard Henderson ha scritto:
>> > @@ -1006,6 +1006,7 @@ void helper_fstenv(CPUX86State *env, target_ulong ptr, int data32)
>> >          cpu_stw_data(env, ptr + 10, 0);
>> >          cpu_stw_data(env, ptr + 12, 0);
>> >      }
>> > +    update_fp_status(env);
>> >  }
> Why does this need to update status?

Ah, this is fstenv (I learnt about it today and misread it as
frstenv...).  The update_fd_status is needed in fldenv, and is missing
from this patch.

TeLeMan's suggestion is also good.

Paolo