From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53810) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XToIk-0005tx-CR for qemu-devel@nongnu.org; Tue, 16 Sep 2014 04:40:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XToId-0006Ik-74 for qemu-devel@nongnu.org; Tue, 16 Sep 2014 04:39:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7636) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XToIc-0006I7-Vv for qemu-devel@nongnu.org; Tue, 16 Sep 2014 04:39:47 -0400 Message-ID: <5417F6EC.2030105@redhat.com> Date: Tue, 16 Sep 2014 10:38:04 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1410792279-2488-1-git-send-email-arei.gonglei@huawei.com> <20140915174900.GA13646@redhat.com> In-Reply-To: <20140915174900.GA13646@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , arei.gonglei@huawei.com Cc: agraf@suse.de, weidong.huang@huawei.com, aliguori@amazon.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, lcapitulino@redhat.com, stefanha@redhat.com Il 15/09/2014 19:49, Michael S. Tsirkin ha scritto: > On Mon, Sep 15, 2014 at 10:44:36PM +0800, arei.gonglei@huawei.com wrote: >> From: Gonglei >> >> At present, people have no way to know they should >> have a specific format for alias properties. >> >> Example: >> >> before output: >> >> virtio-blk-pci.physical_block_size=uint16 >> virtio-blk-pci.logical_block_size=uint16 >> virtio-blk-pci.drive=str >> >> after output applied this patch series: >> >> virtio-blk-pci.physical_block_size=blocksize >> virtio-blk-pci.logical_block_size=blocksize >> virtio-blk-pci.drive=drive >> >> Gonglei (3): >> qom: add error handler for object alias property >> qom: add target object poniter for alias property in ObjectProperty >> qmp: print real legacy_name for alias property >> >> include/qom/object.h | 3 +++ >> qmp.c | 68 ++++++++++++++++++++++++++++++++++++---------------- >> qom/object.c | 10 +++++++- >> 3 files changed, 59 insertions(+), 22 deletions(-) > > fixes regression in 2.1 so 2.1.2 material? Given that there's no known breakage, I don't think so. I'd rather get rid completely of the legacy_name. Paolo