From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XToKB-0007Fo-1a for qemu-devel@nongnu.org; Tue, 16 Sep 2014 04:41:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XToK5-0006vj-QM for qemu-devel@nongnu.org; Tue, 16 Sep 2014 04:41:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38972) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XToK5-0006v0-Hg for qemu-devel@nongnu.org; Tue, 16 Sep 2014 04:41:17 -0400 Message-ID: <5417F746.2030603@redhat.com> Date: Tue, 16 Sep 2014 10:39:34 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1410852392-14184-1-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1410852392-14184-1-git-send-email-arei.gonglei@huawei.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] pit: fix pit interrupt can't inject into vm after migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: ChenLiang , weidong.huang@huawei.com, mst@redhat.com, quintela@redhat.com, aliguori@amazon.com, imammedo@redhat.com, afaerber@suse.de Il 16/09/2014 09:26, arei.gonglei@huawei.com ha scritto: > From: ChenLiang > > kvm_pit is running in kmod. kvm_pit is going to inject > interrupt to vm before cpu_synchronize_all_post_init at > dest side. vcpu will lose the pit interrupt, but > ack_irq(in kmod) has been 0. ack_irq become 1 after > vcpu responds pit interrupt. pit interruptcan inject > to vm when ack_irq is 1. > > By the way, kvm_pit_vm_state_change has save and load > state of pit, so pre_save and post_load is unnecessary. > > Signed-off-by: ChenLiang > Signed-off-by: Gonglei > --- > hw/i386/kvm/i8254.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/hw/i386/kvm/i8254.c b/hw/i386/kvm/i8254.c > index 59373aa..472af81 100644 > --- a/hw/i386/kvm/i8254.c > +++ b/hw/i386/kvm/i8254.c > @@ -239,6 +239,7 @@ static void kvm_pit_vm_state_change(void *opaque, int running, > > if (running) { > kvm_pit_update_clock_offset(s); > + kvm_pit_put(PIT_COMMON(s)); > s->vm_stopped = false; > } else { > kvm_pit_update_clock_offset(s); > @@ -314,8 +315,6 @@ static void kvm_pit_class_init(ObjectClass *klass, void *data) > dc->realize = kvm_pit_realizefn; > k->set_channel_gate = kvm_pit_set_gate; > k->get_channel_info = kvm_pit_get_channel_info; > - k->pre_save = kvm_pit_get; > - k->post_load = kvm_pit_put; > dc->reset = kvm_pit_reset; > dc->props = kvm_pit_properties; > } > Looks good. Thanks, will apply. Paolo