From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48593) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTtQu-00049j-EW for qemu-devel@nongnu.org; Tue, 16 Sep 2014 10:08:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTtQo-0001ed-BJ for qemu-devel@nongnu.org; Tue, 16 Sep 2014 10:08:40 -0400 Received: from mail-qa0-x231.google.com ([2607:f8b0:400d:c00::231]:65036) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTtQn-0001e8-Uu for qemu-devel@nongnu.org; Tue, 16 Sep 2014 10:08:34 -0400 Received: by mail-qa0-f49.google.com with SMTP id i13so5389023qae.22 for ; Tue, 16 Sep 2014 07:08:30 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <54184458.9050802@redhat.com> Date: Tue, 16 Sep 2014 16:08:24 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1410507050-8900-1-git-send-email-arei.gonglei@huawei.com> <33183CC9F5247A488A2544077AF1902086DD646C@SZXEMA503-MBS.china.huawei.com> In-Reply-To: <33183CC9F5247A488A2544077AF1902086DD646C@SZXEMA503-MBS.china.huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gonglei (Arei)" , "qemu-devel@nongnu.org" Cc: "Huangweidong (C)" , "kraxel@redhat.com" , "armbru@redhat.com" Il 16/09/2014 15:54, Gonglei (Arei) ha scritto: >> -----Original Message----- >> From: Gonglei (Arei) >> Sent: Friday, September 12, 2014 3:31 PM >> To: qemu-devel@nongnu.org >> Cc: kraxel@redhat.com; Huangweidong (C); armbru@redhat.com; Gonglei >> (Arei) >> Subject: [PATCH v2 0/2] usb: Don't use qerror_report >> >> From: Gonglei >> >> qerror_report() is a transitional interface to help with converting >> existing HMP commands to QMP. It should not be used elsewhere. >> >> v2 -> v1: >> - update including head files, remove qerror.h and monitor.h, >> add error-report.h (Markus) >> - add 'Reviewed-by' tag. >> >> Gonglei (2): >> redirect.c: Don't use qerror_report() >> dev-network: Don't use qerror_report_err() >> >> hw/usb/dev-network.c | 4 ++-- >> hw/usb/redirect.c | 8 ++++---- >> 2 files changed, 6 insertions(+), 6 deletions(-) >> >> -- >> 1.7.12.4 >> > Hi, Gerd > Would you like to apply this patch series at present? Thanks! I'm not sure what the improvement is? Paolo