From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53219) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTtoR-00028t-Tx for qemu-devel@nongnu.org; Tue, 16 Sep 2014 10:33:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTtoI-0007sc-FT for qemu-devel@nongnu.org; Tue, 16 Sep 2014 10:32:59 -0400 Received: from mail-qa0-x22a.google.com ([2607:f8b0:400d:c00::22a]:55518) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTtoI-0007r2-Az for qemu-devel@nongnu.org; Tue, 16 Sep 2014 10:32:50 -0400 Received: by mail-qa0-f42.google.com with SMTP id j7so5662017qaq.1 for ; Tue, 16 Sep 2014 07:32:46 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <54184A05.1050005@redhat.com> Date: Tue, 16 Sep 2014 16:32:37 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1410620427-20089-1-git-send-email-armbru@redhat.com> <1410620427-20089-9-git-send-email-armbru@redhat.com> <20140916131831.GE27495@nodalink.com> <87a95zk69j.fsf@blackfin.pond.sub.org> In-Reply-To: <87a95zk69j.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 08/23] block: Eliminate BlockDriverState member device_name[] List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com Il 16/09/2014 16:08, Markus Armbruster ha scritto: >>> >> + if (bs->device_list.tqe_prev) { >>> >> QTAILQ_REMOVE(&bdrv_states, bs, device_list); >>> >> + bs->device_list.tqe_prev = NULL; >> > >> > I think a comments explaining the trick you are doing here would be worthy: >> > after all you are touching directly the inner parts of a linked list and >> > bypassing the list API. > Fair enough. Or just add tqe_prev = NULL to QTAILQ_REMOVE. Paolo