From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTu7h-000822-Mz for qemu-devel@nongnu.org; Tue, 16 Sep 2014 10:53:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTu7a-00054f-8V for qemu-devel@nongnu.org; Tue, 16 Sep 2014 10:52:53 -0400 Received: from mail-pd0-f172.google.com ([209.85.192.172]:48082) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTu7a-000543-2U for qemu-devel@nongnu.org; Tue, 16 Sep 2014 10:52:46 -0400 Received: by mail-pd0-f172.google.com with SMTP id v10so8910823pde.31 for ; Tue, 16 Sep 2014 07:52:42 -0700 (PDT) Message-ID: <54184EB2.8020701@ozlabs.ru> Date: Wed, 17 Sep 2014 00:52:34 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <5416C46D.7040105@ozlabs.ru> <541826CA.7050607@ozlabs.ru> <541828BF.8090301@redhat.com> In-Reply-To: <541828BF.8090301@redhat.com> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , "qemu-devel@nongnu.org" , Eric Blake Cc: Kevin Wolf , "Dr. David Alan Gilbert" , Stefan Hajnoczi , Max Reitz On 09/16/2014 10:10 PM, Paolo Bonzini wrote: > Il 16/09/2014 14:02, Alexey Kardashevskiy ha scritto: >> I am having problems when migrate a guest via libvirt like this: >> >> virsh migrate --live --persistent --undefinesource --copy-storage-all >> --verbose --desturi qemu+ssh://legkvm/system --domain chig1 >> >> The XML used to create the guest is at the end of this mail. >> >> I see NBD FLUSH command after the destination QEMU received EOF for >> migration stream and this produces a crash in qcow2_co_flush_to_os() as >> s->lock is false or s->l2_table_cache is NULL. >> > > Max, Kevin, could the fix be something like this? btw this one did not help. > > diff --git a/block/qcow2.c b/block/qcow2.c > index 0daf25c..e7459ea 100644 > --- a/block/qcow2.c > +++ b/block/qcow2.c > @@ -1442,6 +1442,7 @@ static void qcow2_invalidate_cache(BlockDriverState *bs, Error **errp) > memcpy(&aes_decrypt_key, &s->aes_decrypt_key, sizeof(aes_decrypt_key)); > } > > + qemu_co_mutex_lock(&s->lock); > qcow2_close(bs); > > bdrv_invalidate_cache(bs->file, &local_err); > @@ -1455,6 +1456,7 @@ static void qcow2_invalidate_cache(BlockDriverState *bs, Error **errp) > > ret = qcow2_open(bs, options, flags, &local_err); > QDECREF(options); > + qemu_co_mutex_unlock(&s->lock); > if (local_err) { > error_setg(errp, "Could not reopen qcow2 layer: %s", > error_get_pretty(local_err)); > > On top of this, *_invalidate_cache needs to be marked as coroutine_fn. > > Paolo > -- Alexey