From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44574) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTutl-0004ns-OM for qemu-devel@nongnu.org; Tue, 16 Sep 2014 11:42:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTute-0003jM-5N for qemu-devel@nongnu.org; Tue, 16 Sep 2014 11:42:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29046) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTutd-0003i2-Tl for qemu-devel@nongnu.org; Tue, 16 Sep 2014 11:42:26 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8GFgLOa029993 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 16 Sep 2014 11:42:22 -0400 Message-ID: <54185A58.2010105@redhat.com> Date: Tue, 16 Sep 2014 17:42:16 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20140916151437.GA27819@amt.cnet> In-Reply-To: <20140916151437.GA27819@amt.cnet> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] kvmclock: clarify usage of cpu_clean_all_dirty List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcelo Tosatti , qemu-devel Il 16/09/2014 17:14, Marcelo Tosatti ha scritto: > + /* > + * Make sure that CPU state is synchronized from KVM > + * once every VM state change callback has finished. Which other callback could affect the in-kernel state, and should that call cpu_clean_all_dirty instead? Paolo > + */ > cpu_clean_all_dirty();