From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTvXe-0002ai-Ak for qemu-devel@nongnu.org; Tue, 16 Sep 2014 12:23:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTvXY-0007KP-6M for qemu-devel@nongnu.org; Tue, 16 Sep 2014 12:23:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54187) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTvXX-0007K5-Vi for qemu-devel@nongnu.org; Tue, 16 Sep 2014 12:23:40 -0400 Message-ID: <54186401.9040705@redhat.com> Date: Tue, 16 Sep 2014 18:23:29 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1410882204-9836-1-git-send-email-pbonzini@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers , Eduardo Habkost , "Michael S. Tsirkin" Il 16/09/2014 18:20, Peter Maydell ha scritto: >> > - bumping the minimum required version from 2.12 to 2.16. I suggest >> > bumping to the currently required version for Windows, which is 2.20 >> > (released March 2009). > The commit message for a52d28afb suggests that this bump would be > dropping support for RHEL5. That doesn't seem like a great idea > to me, especially if it's only for the benefit of a test program. Though you would just drop support for "make check" on RHEL5. Even "make -k check" would roughly work. > On the other hand your patch doesn't actually bump the required > version, so I'm a bit confused. Yeah, this is just an RFC. Paolo