From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58000)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XTvbz-0004wY-6e
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 12:28:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XTvbt-00009R-2H
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 12:28:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:62172)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XTvbs-000098-RK
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 12:28:08 -0400
Message-ID: <54186507.2070405@redhat.com>
Date: Tue, 16 Sep 2014 18:27:51 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1410792279-2488-1-git-send-email-arei.gonglei@huawei.com>
	<54170C7F.8080409@redhat.com> <20140915174503.GB13548@redhat.com>
	<87wq94xc7v.fsf@blackfin.pond.sub.org>
	<5417F698.2060001@redhat.com>
	<87sijsq60x.fsf@blackfin.pond.sub.org>
	<5418040F.3020106@redhat.com> <20140916103709.GA17910@redhat.com>
	<541814D7.8040300@redhat.com> <20140916162634.GA2195@redhat.com>
In-Reply-To: <20140916162634.GA2195@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias
	properties
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: weidong.huang@huawei.com, aliguori@amazon.com, qemu-devel@nongnu.org, agraf@suse.de, Markus Armbruster <armbru@redhat.com>, arei.gonglei@huawei.com, stefanha@redhat.com, peter.huangpeng@huawei.com, lcapitulino@redhat.com

Il 16/09/2014 18:26, Michael S. Tsirkin ha scritto:
> Right so types should be explicit.
> If an arbitrary string isn't allowed, this should be documented.
> It's not great as is: what's the format for macaddr? AA:BB:CC:DD:EE:FF?
> aa:bb:cc:dd:ee:ff? aabbccddeeff? 0xaabbccddeeff?
> But just saying "string" is going in the wrong direction imho.

That's the purpose of documentation (docs/qdev-device-use.txt), and even
then is better done with examples.  I don't think doing it in -device
foo,help (which I'm not even sure is particularly helpful.

"ip link help" doesn't document the format of a MAC address, either.

I'm sympathetic towards fixing the drive->str change, but I have no idea
how to do it.

Paolo