From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59637) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTvhh-00089F-GA for qemu-devel@nongnu.org; Tue, 16 Sep 2014 12:34:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTvhb-0001pk-BF for qemu-devel@nongnu.org; Tue, 16 Sep 2014 12:34:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16343) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTvhb-0001pU-34 for qemu-devel@nongnu.org; Tue, 16 Sep 2014 12:34:03 -0400 Message-ID: <54186670.1010604@redhat.com> Date: Tue, 16 Sep 2014 18:33:52 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1410882204-9836-1-git-send-email-pbonzini@redhat.com> <54186401.9040705@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers , Eduardo Habkost , "Michael S. Tsirkin" Il 16/09/2014 18:28, Peter Maydell ha scritto: >> > Though you would just drop support for "make check" on RHEL5. Even >> > "make -k check" would roughly work. > Can't we just put in the makefile and configure magic to skip > the test if the glib version is too old for it? Yes, that's what Michael did (minus the magic to use the older fork-based code). But is it really worthwhile to support RHEL5? We made glib mandatory in 2011 (around RHEL6.2), and that broke RHEL4. By the time the next QEMU release is ready RHEL7.1 should be out, give or take a month or so. Paolo