From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38692) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUC1b-0007sy-4I for qemu-devel@nongnu.org; Wed, 17 Sep 2014 05:59:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUC1U-0004nk-5i for qemu-devel@nongnu.org; Wed, 17 Sep 2014 05:59:47 -0400 Received: from [59.151.112.132] (port=36612 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUC1T-0004mm-Qx for qemu-devel@nongnu.org; Wed, 17 Sep 2014 05:59:40 -0400 Message-ID: <54195BDB.9060604@cn.fujitsu.com> Date: Wed, 17 Sep 2014 18:00:59 +0800 From: Tang Chen MIME-Version: 1.0 References: <1410863956-11056-1-git-send-email-zhang.zhanghailiang@huawei.com> <1410863956-11056-2-git-send-email-zhang.zhanghailiang@huawei.com> <20140917083220.GA17032@G08FNSTD100614.fnst.cn.fujitsu.com> In-Reply-To: <20140917083220.GA17032@G08FNSTD100614.fnst.cn.fujitsu.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao , zhanghailiang Cc: Andrey Korolyov , mst@redhat.com, luonengjun@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, imammedo@redhat.com, pbonzini@redhat.com, tangchen@cn.fujitsu.com, gaowanlong@cn.fujitsu.com Add Andrey Korolyov On 09/17/2014 04:32 PM, Hu Tao wrote: > On Tue, Sep 16, 2014 at 06:39:15PM +0800, zhanghailiang wrote: >> If we do not configure numa option, memory hotplug should work as well. >> It should not depend on numa option. >> >> Steps to reproduce: >> (1) Start VM: qemu-kvm -m 1024,slots=4,maxmem=8G >> (2) Hotplug memory >> It will fail and reports: >> "'DIMM property node has value 0' which exceeds the number of numa nodes: 0" >> > I rememberd Tang Chen had a patch for this bug, this is what Andrey suggested: > > I thnk that there should be no > cases when dimm is plugged (and check from patch is fired up) without > actually populated NUMA, because not every OS will workaround this by > faking the node. According to Andrey Korolyov , memory hotplug should not work without SRAT. So maybe forcing to create a NUMA node and SRAT will be better idea. I'm have been working on it. Thanks. > > https://lists.nongnu.org/archive/html/qemu-devel/2014-08/msg04587.html > > Have you tested this patch with Windows guest? > > Regards, > Hu > >