From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUEoe-00015a-JI for qemu-devel@nongnu.org; Wed, 17 Sep 2014 08:58:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUEoZ-0007A5-KQ for qemu-devel@nongnu.org; Wed, 17 Sep 2014 08:58:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20127) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUEoZ-00079T-CU for qemu-devel@nongnu.org; Wed, 17 Sep 2014 08:58:31 -0400 Message-ID: <5419856A.6030402@redhat.com> Date: Wed, 17 Sep 2014 06:58:18 -0600 From: Eric Blake MIME-Version: 1.0 References: <54170C7F.8080409@redhat.com> <20140915174503.GB13548@redhat.com> <87wq94xc7v.fsf@blackfin.pond.sub.org> <5417F698.2060001@redhat.com> <87sijsq60x.fsf@blackfin.pond.sub.org> <5418040F.3020106@redhat.com> <20140916103709.GA17910@redhat.com> <541814D7.8040300@redhat.com> <20140916162634.GA2195@redhat.com> <54186507.2070405@redhat.com> <20140916165618.GC8628@redhat.com> <541881EC.4090508@redhat.com> <541896E9.4090806@redhat.com> <874mw6yeph.fsf@blackfin.pond.sub.org> In-Reply-To: <874mw6yeph.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ek1c1CEFkKiaCBDsiCONxogS5UWEb6V8I" Subject: Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: weidong.huang@huawei.com, aliguori@amazon.com, "Michael S. Tsirkin" , qemu-devel@nongnu.org, agraf@suse.de, arei.gonglei@huawei.com, stefanha@redhat.com, Paolo Bonzini , peter.huangpeng@huawei.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Ek1c1CEFkKiaCBDsiCONxogS5UWEb6V8I Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/16/2014 11:54 PM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> On 09/16/2014 12:31 PM, Paolo Bonzini wrote: >> >>>> Change legacy_name to point to a detailed human-readable >>>> description of the type? >>>> E.g. "Ethernet 6-byte MAC Address, format: AA:BB:CC:DD:EE:FF"? >>> >>> If libvirt can cope with >>> >>> e1000.mac=3Dstr (Ethernet 6-byte MAC Address, format: AA:BB:CC:DD:EE:= FF) >> >> Isn't this output only available under -help? Libvirt only cares about= >> QMP listings of devices and their properties, so improving the human >> interface should have no negative impact to the machine interface. >=20 > Libvirt still has code parsing this, see virQEMUCapsExtractDeviceStr().= > Whether it's actually used with recent QEMU I don't know. That code is only used for qemu < 1.5 (when -help parsing is all we can use) - but those versions of qemu are not going to change -help output, and new versions of qemu use only QMP, so you are free to change it with no impact to libvirt. >=20 > -device FOO,help merely formats qmp_device_list_properties()'s value fo= r > human consumption. So, to make a description string available for help= , > we also have to put it into the function's value. If we don't want it > in QMP, we need to filter it out in the command handler. Right now, > qmp_device_list_properties() *is* the command handler. >=20 > Aside: why isn't the QMP command named query-device-list-properties? W= e > suck at consistency! >=20 >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Ek1c1CEFkKiaCBDsiCONxogS5UWEb6V8I Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUGYVqAAoJEKeha0olJ0NqLHgH/0Z/vuO4a52dOmMRheaHg0sb oGX7C8SEySFltrsanc538xDqmeUYS4brEnGhi62cLxAgI1yyI9zdIkKKChsC0UdK lR4zxUhz+QqWAeNSAX1KRsDntEP6MRpxilKhsvTr7hB9eAWLEf/OpuwR0wstdnHo HMrmchmO2yKBL+ljt76+pkDQD2UwwjS8IDVvIL328Y+WgN7N2z8YYROwFhAcZV9Y 0XNuiO//0ux/6OC4WOpjPAmGKhiv+3wyWozJqWfyduQXZFbNtNzKK7gkl4/fxJEn cd6AGKuYe8teRsGrK9ZUC2pzlEvG2cor4Zki+A0Xg6yiZaHe+3LPegyDul/WiYQ= =Tbb9 -----END PGP SIGNATURE----- --Ek1c1CEFkKiaCBDsiCONxogS5UWEb6V8I--