From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57865) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUH4E-0004ts-J0 for qemu-devel@nongnu.org; Wed, 17 Sep 2014 11:22:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUH45-0006ex-Ic for qemu-devel@nongnu.org; Wed, 17 Sep 2014 11:22:50 -0400 Received: from mail-pd0-x229.google.com ([2607:f8b0:400e:c02::229]:43387) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUH45-0006eF-Bt for qemu-devel@nongnu.org; Wed, 17 Sep 2014 11:22:41 -0400 Received: by mail-pd0-f169.google.com with SMTP id fp1so2342457pdb.28 for ; Wed, 17 Sep 2014 08:22:37 -0700 (PDT) Sender: Richard Henderson Message-ID: <5419A736.1050605@twiddle.net> Date: Wed, 17 Sep 2014 08:22:30 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1410626734-3804-1-git-send-email-rth@twiddle.net> <1410626734-3804-2-git-send-email-rth@twiddle.net> <5419765C.1090803@suse.de> In-Reply-To: <5419765C.1090803@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 01/23] qom: Add cpu_exec_enter and cpu_exec_exit hooks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, =?UTF-8?B?QWxleCBCZW5u?= =?UTF-8?B?w6ll?= , aliguori@amazon.com On 09/17/2014 04:54 AM, Andreas Färber wrote: > I am fine with adding such hooks, but please let's use a better, active > name. CPUClass is the struct name and cpu-exec is a file name; the hook > should say what it's doing, not where the code (used to) live(s). Just > exec_enter/exec_exit possibly? cpu_exec is also the function name from which they're invoked, not just the file name. I can make the name change if you really prefer, but (perhaps obviously) I kinda like the current naming. r~