From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35574)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XUHVh-0004SV-Ka
	for qemu-devel@nongnu.org; Wed, 17 Sep 2014 11:51:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XUHVb-00064r-EL
	for qemu-devel@nongnu.org; Wed, 17 Sep 2014 11:51:13 -0400
Message-ID: <5419ADDF.7020501@redhat.com>
Date: Wed, 17 Sep 2014 17:50:55 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1410793421-6453-1-git-send-email-pbonzini@redhat.com>	<1410793421-6453-4-git-send-email-pbonzini@redhat.com>	<5418716A.9080508@gmail.com>
	<54187B3D.8000909@twiddle.net>	<5418810E.3080100@redhat.com>
	<5418846E.8070608@twiddle.net>	<5418B877.8080308@twiddle.net>
	<1959651544.50247750.1410934939759.JavaMail.zimbra@redhat.com>
	<54194BF9.7010102@redhat.com> <5419A9E0.7000703@twiddle.net>
In-Reply-To: <5419A9E0.7000703@twiddle.net>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 03/14] target-ppc: use separate indices for
 various translation modes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: Peter Maydell <peter.maydell@linaro.org>, Tom Musta <tommusta@gmail.com>, qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org

Il 17/09/2014 17:33, Richard Henderson ha scritto:
> Hum.  Well, it's not that all the tlbs together that must be less than 64k,
> it's the addend of the first entry of the last tlb that must be within 64k of
> the start of env.  Nit picking, but perhaps we can word the comment better.

Indeed.

> And if we choose to do something like this, this is where I'd prefer a define
> in the relevant tcg-target.h.  Because you've missed ia64 and s390 that have
> positive offsets larger than 64k (21 and 19 bits, respectively).

Right, but with 16 MMU modes the maximum size is 128k, well within s390
and ia64's limits.

> But otherwise I'm ok with this as a solution.

Thanks!

Paolo