From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44762) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUOVi-00050X-Ib for qemu-devel@nongnu.org; Wed, 17 Sep 2014 19:19:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUOVc-0004aD-5z for qemu-devel@nongnu.org; Wed, 17 Sep 2014 19:19:42 -0400 Received: from resqmta-po-05v.sys.comcast.net ([96.114.154.164]:40321) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUOVc-0004ZS-0z for qemu-devel@nongnu.org; Wed, 17 Sep 2014 19:19:36 -0400 Message-ID: <541A0C40.2030900@redhat.com> Date: Wed, 17 Sep 2014 16:33:36 -0600 From: Eric Blake MIME-Version: 1.0 References: <1410989576-9311-1-git-send-email-mdroth@linux.vnet.ibm.com> <1410989576-9311-4-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1410989576-9311-4-git-send-email-mdroth@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="A7tp0HU75HWx3tlAgrBrjhC6IpWrp3j1H" Subject: Re: [Qemu-devel] [PATCH v2 3/4] tests: add QMP input visitor test for unions with no discriminator List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, lcapitulino@redhat.com, famz@redhat.com, qemu-stable@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --A7tp0HU75HWx3tlAgrBrjhC6IpWrp3j1H Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/17/2014 03:32 PM, Michael Roth wrote: > This more of an exercise of the dealloc visitor, where it may s/This more/This is more/ > erroneously use an uninitialized discriminator field as indication > that union fields corresponding to that discriminator field/type are > present, which can lead to attempts to free random chunks of heap > memory. >=20 > Cc: qemu-stable@nongnu.org > Reviewed-by: Eric Blake > Reviewed-by: Paolo Bonzini > Signed-off-by: Michael Roth > --- > tests/qapi-schema/qapi-schema-test.json | 10 ++++++++++ > tests/qapi-schema/qapi-schema-test.out | 3 +++ > tests/test-qmp-input-strict.c | 17 +++++++++++++++++ > 3 files changed, 30 insertions(+) >=20 R-b still stands. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --A7tp0HU75HWx3tlAgrBrjhC6IpWrp3j1H Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUGgxAAAoJEKeha0olJ0NqQWsH/jreGrcxZ+Ob0ZVKvs+5/imC p1KJHWBBkINpH4+/Kko3DKM80xAhIrB9rcxsztWDXBexuicrUQb/Y8HOBBuVMjbW 38x/MAKL5WiB/dkmt1rSyVrStt93Qvl6rQoZ82+cHcA9qw9Jtm99gZPMBZ5iNntC 6E5h02wsun8iwhF2EJJbSkl5sIHY68Q5pw5dDFPLZEupR1x5X+1MlrdkgcPp6ou5 PCLYZQXNDA/SnJ+vRBiTAEDOXpE8KRNCBHsynXKNdJVg3Zff7XxSXUY7UB8cX5dC +WdY7xgLigTv+1Z2Z+AupxN6OBeV7e+CJhgozrNBPuhUbOpKm3U2JJrf/jAx5Cg= =Ph89 -----END PGP SIGNATURE----- --A7tp0HU75HWx3tlAgrBrjhC6IpWrp3j1H--