From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57663)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XUYeZ-0001WK-5r
	for qemu-devel@nongnu.org; Thu, 18 Sep 2014 06:09:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XUYeU-0004VX-C6
	for qemu-devel@nongnu.org; Thu, 18 Sep 2014 06:09:31 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37019)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XUYeT-0004Tk-Vv
	for qemu-devel@nongnu.org; Thu, 18 Sep 2014 06:09:26 -0400
Message-ID: <541AAF42.3050908@redhat.com>
Date: Thu, 18 Sep 2014 12:09:06 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1411032780-10692-1-git-send-email-arei.gonglei@huawei.com>
	<1411032780-10692-3-git-send-email-arei.gonglei@huawei.com>
In-Reply-To: <1411032780-10692-3-git-send-email-arei.gonglei@huawei.com>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 02/19] usb-bus: convert USBDeviceClass init
	to realize
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: arei.gonglei@huawei.com, qemu-devel@nongnu.org
Cc: luonengjun@huawei.com, peter.huangpeng@huawei.com, weidong.huang@huawei.com, kraxel@redhat.com, armbru@redhat.com

Il 18/09/2014 11:32, arei.gonglei@huawei.com ha scritto:
>  static void usb_msd_password_cb(void *opaque, int err)
>  {
>      MSDState *s = opaque;
> +    Error *local_err = NULL;
>  
> -    if (!err)
> -        err = usb_device_attach(&s->dev);
> +    if (!err) {
> +        usb_device_attach(&s->dev, &local_err);
> +    }
>  
> -    if (err)
> +    if (local_err) {
> +        error_report("%s", error_get_pretty(local_err));

I think this should use qerror_report_err.

Paolo