From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUYih-0006KK-Iv for qemu-devel@nongnu.org; Thu, 18 Sep 2014 06:13:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUYic-0005x8-PZ for qemu-devel@nongnu.org; Thu, 18 Sep 2014 06:13:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61519) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUYic-0005w1-GR for qemu-devel@nongnu.org; Thu, 18 Sep 2014 06:13:42 -0400 Message-ID: <541AB048.80709@redhat.com> Date: Thu, 18 Sep 2014 12:13:28 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1411032780-10692-1-git-send-email-arei.gonglei@huawei.com> <1411032780-10692-9-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1411032780-10692-9-git-send-email-arei.gonglei@huawei.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 08/19] dev-storage: usring error_report instead of fprintf/printf List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: luonengjun@huawei.com, peter.huangpeng@huawei.com, weidong.huang@huawei.com, kraxel@redhat.com, armbru@redhat.com Il 18/09/2014 11:32, arei.gonglei@huawei.com ha scritto: > From: Gonglei > > Signed-off-by: Gonglei > --- > hw/usb/dev-storage.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c > index 6dc5f47..681959d 100644 > --- a/hw/usb/dev-storage.c > +++ b/hw/usb/dev-storage.c > @@ -409,19 +409,19 @@ static void usb_msd_handle_data(USBDevice *dev, USBPacket *p) > switch (s->mode) { > case USB_MSDM_CBW: > if (p->iov.size != 31) { > - fprintf(stderr, "usb-msd: Bad CBW size"); > + error_report("usb-msd: Bad CBW size"); > goto fail; > } > usb_packet_copy(p, &cbw, 31); > if (le32_to_cpu(cbw.sig) != 0x43425355) { > - fprintf(stderr, "usb-msd: Bad signature %08x\n", > - le32_to_cpu(cbw.sig)); > + error_report("usb-msd: Bad signature %08x", > + le32_to_cpu(cbw.sig)); > goto fail; > } > DPRINTF("Command on LUN %d\n", cbw.lun); > scsi_dev = scsi_device_find(&s->bus, 0, 0, cbw.lun); > if (scsi_dev == NULL) { > - fprintf(stderr, "usb-msd: Bad LUN %d\n", cbw.lun); > + error_report("usb-msd: Bad LUN %d", cbw.lun); > goto fail; > } > tag = le32_to_cpu(cbw.tag); > @@ -680,13 +680,13 @@ static USBDevice *usb_msd_init(USBBus *bus, const char *filename) > pstrcpy(fmt, len, p2); > qemu_opt_set(opts, "format", fmt); > } else if (*filename != ':') { > - printf("unrecognized USB mass-storage option %s\n", filename); > + error_report("unrecognized USB mass-storage option %s", filename); > return NULL; > } > filename = p1; > } > if (!*filename) { > - printf("block device specification needed\n"); > + error_report("block device specification needed"); > return NULL; > } > qemu_opt_set(opts, "file", filename); > Reviewed-by: Paolo Bonzini