From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUYin-0006TE-O0 for qemu-devel@nongnu.org; Thu, 18 Sep 2014 06:13:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUYii-0005zF-UR for qemu-devel@nongnu.org; Thu, 18 Sep 2014 06:13:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21096) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUYii-0005xX-N7 for qemu-devel@nongnu.org; Thu, 18 Sep 2014 06:13:48 -0400 Message-ID: <541AB04F.5030807@redhat.com> Date: Thu, 18 Sep 2014 12:13:35 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1411032780-10692-1-git-send-email-arei.gonglei@huawei.com> <1411032780-10692-10-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1411032780-10692-10-git-send-email-arei.gonglei@huawei.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/19] dev-uas: convert init to realize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: luonengjun@huawei.com, peter.huangpeng@huawei.com, weidong.huang@huawei.com, kraxel@redhat.com, armbru@redhat.com Il 18/09/2014 11:32, arei.gonglei@huawei.com ha scritto: > From: Gonglei > > Signed-off-by: Gonglei > --- > hw/usb/dev-uas.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/hw/usb/dev-uas.c b/hw/usb/dev-uas.c > index 9832385..884c003 100644 > --- a/hw/usb/dev-uas.c > +++ b/hw/usb/dev-uas.c > @@ -892,7 +892,7 @@ static void usb_uas_handle_destroy(USBDevice *dev) > qemu_bh_delete(uas->status_bh); > } > > -static int usb_uas_init(USBDevice *dev) > +static void usb_uas_realize(USBDevice *dev, Error **errp) > { > UASDevice *uas = DO_UPCAST(UASDevice, dev, dev); > > @@ -905,8 +905,6 @@ static int usb_uas_init(USBDevice *dev) > > scsi_bus_new(&uas->bus, sizeof(uas->bus), DEVICE(dev), > &usb_uas_scsi_info, NULL); > - > - return 0; > } > > static const VMStateDescription vmstate_usb_uas = { > @@ -928,7 +926,7 @@ static void usb_uas_class_initfn(ObjectClass *klass, void *data) > DeviceClass *dc = DEVICE_CLASS(klass); > USBDeviceClass *uc = USB_DEVICE_CLASS(klass); > > - uc->init = usb_uas_init; > + uc->realize = usb_uas_realize; > uc->product_desc = desc_strings[STR_PRODUCT]; > uc->usb_desc = &desc; > uc->cancel_packet = usb_uas_cancel_io; > Reviewed-by: Paolo Bonzini