From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59206)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XUYjG-0007HQ-Sy
	for qemu-devel@nongnu.org; Thu, 18 Sep 2014 06:14:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XUYjB-0006BG-WD
	for qemu-devel@nongnu.org; Thu, 18 Sep 2014 06:14:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57829)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XUYjB-0006Av-Nm
	for qemu-devel@nongnu.org; Thu, 18 Sep 2014 06:14:17 -0400
Message-ID: <541AB06C.5090205@redhat.com>
Date: Thu, 18 Sep 2014 12:14:04 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1411032780-10692-1-git-send-email-arei.gonglei@huawei.com>
	<1411032780-10692-11-git-send-email-arei.gonglei@huawei.com>
In-Reply-To: <1411032780-10692-11-git-send-email-arei.gonglei@huawei.com>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 10/19] dev-uas: using error_report instead
	of fprintf
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: arei.gonglei@huawei.com, qemu-devel@nongnu.org
Cc: luonengjun@huawei.com, peter.huangpeng@huawei.com, weidong.huang@huawei.com, kraxel@redhat.com, armbru@redhat.com

Il 18/09/2014 11:32, arei.gonglei@huawei.com ha scritto:
> From: Gonglei <arei.gonglei@huawei.com>
> 
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
>  hw/usb/dev-uas.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/hw/usb/dev-uas.c b/hw/usb/dev-uas.c
> index 884c003..1508064 100644
> --- a/hw/usb/dev-uas.c
> +++ b/hw/usb/dev-uas.c
> @@ -13,6 +13,7 @@
>  #include "qemu/option.h"
>  #include "qemu/config-file.h"
>  #include "trace.h"
> +#include "qemu/error-report.h"
>  
>  #include "hw/usb.h"
>  #include "hw/usb/desc.h"
> @@ -648,7 +649,7 @@ static void usb_uas_handle_control(USBDevice *dev, USBPacket *p,
>      if (ret >= 0) {
>          return;
>      }
> -    fprintf(stderr, "%s: unhandled control request\n", __func__);
> +    error_report("%s: unhandled control request", __func__);
>      p->status = USB_RET_STALL;
>  }
>  
> @@ -814,8 +815,8 @@ static void usb_uas_handle_data(USBDevice *dev, USBPacket *p)
>              usb_uas_task(uas, &iu);
>              break;
>          default:
> -            fprintf(stderr, "%s: unknown command iu: id 0x%x\n",
> -                    __func__, iu.hdr.id);
> +            error_report("%s: unknown command iu: id 0x%x",
> +                         __func__, iu.hdr.id);
>              p->status = USB_RET_STALL;
>              break;
>          }
> @@ -861,7 +862,7 @@ static void usb_uas_handle_data(USBDevice *dev, USBPacket *p)
>                  p->status = USB_RET_ASYNC;
>                  break;
>              } else {
> -                fprintf(stderr, "%s: no inflight request\n", __func__);
> +                error_report("%s: no inflight request", __func__);
>                  p->status = USB_RET_STALL;
>                  break;
>              }
> @@ -879,7 +880,7 @@ static void usb_uas_handle_data(USBDevice *dev, USBPacket *p)
>          usb_uas_start_next_transfer(uas);
>          break;
>      default:
> -        fprintf(stderr, "%s: invalid endpoint %d\n", __func__, p->ep->nr);
> +        error_report("%s: invalid endpoint %d", __func__, p->ep->nr);
>          p->status = USB_RET_STALL;
>          break;
>      }
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>