From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59244) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUYjR-0007Zo-JK for qemu-devel@nongnu.org; Thu, 18 Sep 2014 06:14:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUYjM-0006D6-Lr for qemu-devel@nongnu.org; Thu, 18 Sep 2014 06:14:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28035) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUYjM-0006Ca-BZ for qemu-devel@nongnu.org; Thu, 18 Sep 2014 06:14:28 -0400 Message-ID: <541AB077.5020408@redhat.com> Date: Thu, 18 Sep 2014 12:14:15 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1411032780-10692-1-git-send-email-arei.gonglei@huawei.com> <1411032780-10692-12-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1411032780-10692-12-git-send-email-arei.gonglei@huawei.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 11/19] dev-bluetooth: convert init to realize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: luonengjun@huawei.com, peter.huangpeng@huawei.com, weidong.huang@huawei.com, kraxel@redhat.com, armbru@redhat.com Il 18/09/2014 11:32, arei.gonglei@huawei.com ha scritto: > From: Gonglei > > Signed-off-by: Gonglei > --- > hw/usb/dev-bluetooth.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/hw/usb/dev-bluetooth.c b/hw/usb/dev-bluetooth.c > index a76e581..7db9921 100644 > --- a/hw/usb/dev-bluetooth.c > +++ b/hw/usb/dev-bluetooth.c > @@ -501,7 +501,7 @@ static void usb_bt_handle_destroy(USBDevice *dev) > s->hci->acl_recv = NULL; > } > > -static int usb_bt_initfn(USBDevice *dev) > +static void usb_bt_realize(USBDevice *dev, Error **errp) > { > struct USBBtState *s = DO_UPCAST(struct USBBtState, dev, dev); > > @@ -516,8 +516,6 @@ static int usb_bt_initfn(USBDevice *dev) > s->hci->acl_recv = usb_bt_out_hci_packet_acl; > usb_bt_handle_reset(&s->dev); > s->intr = usb_ep_get(dev, USB_TOKEN_IN, USB_EVT_EP); > - > - return 0; > } > > static USBDevice *usb_bt_init(USBBus *bus, const char *cmdline) > @@ -560,7 +558,7 @@ static void usb_bt_class_initfn(ObjectClass *klass, void *data) > DeviceClass *dc = DEVICE_CLASS(klass); > USBDeviceClass *uc = USB_DEVICE_CLASS(klass); > > - uc->init = usb_bt_initfn; > + uc->realize = usb_bt_realize; > uc->product_desc = "QEMU BT dongle"; > uc->usb_desc = &desc_bluetooth; > uc->handle_reset = usb_bt_handle_reset; > Reviewed-by: Paolo Bonzini