From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59628)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XUYl4-0001og-7k
	for qemu-devel@nongnu.org; Thu, 18 Sep 2014 06:16:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XUYkw-0006jV-KX
	for qemu-devel@nongnu.org; Thu, 18 Sep 2014 06:16:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55028)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XUYkw-0006iy-Ch
	for qemu-devel@nongnu.org; Thu, 18 Sep 2014 06:16:06 -0400
Message-ID: <541AB0D8.4000705@redhat.com>
Date: Thu, 18 Sep 2014 12:15:52 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1411032780-10692-1-git-send-email-arei.gonglei@huawei.com>
	<1411032780-10692-16-git-send-email-arei.gonglei@huawei.com>
In-Reply-To: <1411032780-10692-16-git-send-email-arei.gonglei@huawei.com>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 15/19] dev-wacom: convert init to realize
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: arei.gonglei@huawei.com, qemu-devel@nongnu.org
Cc: luonengjun@huawei.com, peter.huangpeng@huawei.com, weidong.huang@huawei.com, kraxel@redhat.com, armbru@redhat.com

Il 18/09/2014 11:32, arei.gonglei@huawei.com ha scritto:
> From: Gonglei <arei.gonglei@huawei.com>
> 
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
>  hw/usb/dev-wacom.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/usb/dev-wacom.c b/hw/usb/dev-wacom.c
> index 1b73fd0..217d48e 100644
> --- a/hw/usb/dev-wacom.c
> +++ b/hw/usb/dev-wacom.c
> @@ -335,14 +335,13 @@ static void usb_wacom_handle_destroy(USBDevice *dev)
>      }
>  }
>  
> -static int usb_wacom_initfn(USBDevice *dev)
> +static void usb_wacom_realize(USBDevice *dev, Error **errp)
>  {
>      USBWacomState *s = DO_UPCAST(USBWacomState, dev, dev);
>      usb_desc_create_serial(dev);
>      usb_desc_init(dev);
>      s->intr = usb_ep_get(dev, USB_TOKEN_IN, 1);
>      s->changed = 1;
> -    return 0;
>  }
>  
>  static const VMStateDescription vmstate_usb_wacom = {
> @@ -357,7 +356,7 @@ static void usb_wacom_class_init(ObjectClass *klass, void *data)
>  
>      uc->product_desc   = "QEMU PenPartner Tablet";
>      uc->usb_desc       = &desc_wacom;
> -    uc->init           = usb_wacom_initfn;
> +    uc->realize           = usb_wacom_realize;
>      uc->handle_reset   = usb_wacom_handle_reset;
>      uc->handle_control = usb_wacom_handle_control;
>      uc->handle_data    = usb_wacom_handle_data;
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>