From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59791)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XUYll-00034L-TR
	for qemu-devel@nongnu.org; Thu, 18 Sep 2014 06:17:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XUYlh-0006sj-4D
	for qemu-devel@nongnu.org; Thu, 18 Sep 2014 06:16:57 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57670)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XUYlg-0006qR-U2
	for qemu-devel@nongnu.org; Thu, 18 Sep 2014 06:16:53 -0400
Message-ID: <541AB107.1020506@redhat.com>
Date: Thu, 18 Sep 2014 12:16:39 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1411032780-10692-1-git-send-email-arei.gonglei@huawei.com>
	<1411032780-10692-19-git-send-email-arei.gonglei@huawei.com>
In-Reply-To: <1411032780-10692-19-git-send-email-arei.gonglei@huawei.com>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 18/19] usb-mtp: convert init to realize
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: arei.gonglei@huawei.com, qemu-devel@nongnu.org
Cc: luonengjun@huawei.com, peter.huangpeng@huawei.com, weidong.huang@huawei.com, kraxel@redhat.com, armbru@redhat.com

Il 18/09/2014 11:32, arei.gonglei@huawei.com ha scritto:
> From: Gonglei <arei.gonglei@huawei.com>
> 
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
>  hw/usb/dev-mtp.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
> index 0820046..108ece8 100644
> --- a/hw/usb/dev-mtp.c
> +++ b/hw/usb/dev-mtp.c
> @@ -1060,7 +1060,7 @@ static void usb_mtp_handle_data(USBDevice *dev, USBPacket *p)
>      }
>  }
>  
> -static int usb_mtp_initfn(USBDevice *dev)
> +static void usb_mtp_realize(USBDevice *dev, Error **errp)
>  {
>      MTPState *s = DO_UPCAST(MTPState, dev, dev);
>  
> @@ -1075,7 +1075,6 @@ static int usb_mtp_initfn(USBDevice *dev)
>              s->desc = g_strdup("none");
>          }
>      }
> -    return 0;
>  }
>  
>  static const VMStateDescription vmstate_usb_mtp = {
> @@ -1100,7 +1099,7 @@ static void usb_mtp_class_initfn(ObjectClass *klass, void *data)
>      DeviceClass *dc = DEVICE_CLASS(klass);
>      USBDeviceClass *uc = USB_DEVICE_CLASS(klass);
>  
> -    uc->init           = usb_mtp_initfn;
> +    uc->realize        = usb_mtp_realize;
>      uc->product_desc   = "QEMU USB MTP";
>      uc->usb_desc       = &desc;
>      uc->cancel_packet  = usb_mtp_cancel_packet;
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>