From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35050) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUb9X-0005hX-3Y for qemu-devel@nongnu.org; Thu, 18 Sep 2014 08:49:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUb9S-0006LN-56 for qemu-devel@nongnu.org; Thu, 18 Sep 2014 08:49:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8775) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUb9R-0006Kk-T3 for qemu-devel@nongnu.org; Thu, 18 Sep 2014 08:49:34 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8ICnSDt026095 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 18 Sep 2014 08:49:28 -0400 Message-ID: <541AD4D7.8030908@redhat.com> Date: Thu, 18 Sep 2014 06:49:27 -0600 From: Eric Blake MIME-Version: 1.0 References: <1410881796-18452-1-git-send-email-kwolf@redhat.com> <1410881796-18452-2-git-send-email-kwolf@redhat.com> <87a95xw5on.fsf@blackfin.pond.sub.org> <20140918115342.GC3761@noname.redhat.com> In-Reply-To: <20140918115342.GC3761@noname.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CmIgqG7taeW01srPj8bi9sQsQPcsPqXqr" Subject: Re: [Qemu-devel] [PATCH 1/6] block/qapi: Add cache information to query-block List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Markus Armbruster Cc: qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CmIgqG7taeW01srPj8bi9sQsQPcsPqXqr Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/18/2014 05:53 AM, Kevin Wolf wrote: > Am 18.09.2014 um 13:04 hat Markus Armbruster geschrieben: >> Before this patch, QAPI type BlockdevCacheOptions is used only as a >> member of BlockdevOptionsBase. >> >> BlockdevOptionsBase is a collection configuration settings. >> Consequently, it's a complex type whose members are optional exactly >> when the configuration setting is optional. Makes sense. >> >> Complication: a few options are wrapped in another complex type, >> BlockdevCacheOptions. It's optional, but that's not sufficient, it's >> members are all optional, too. >> > I think the choice is between adding BlockdevCacheInfo and changing > documentation while reusing BlockdevCacheOptions. Both are fine with me= =2E > Which one do you prefer? Those two options sound the best to me as well; I'm fine with either, although I have a slight preference for just documenting on BlockdevCacheOptions that members are optional on input but will all be present when generated as output. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --CmIgqG7taeW01srPj8bi9sQsQPcsPqXqr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUGtTXAAoJEKeha0olJ0Nqlj8H/j3i5judlBOMbE42/pIOrZ2Q rH7fZeZajfbRxHotRXATz9isAZCnFwMurqHoOFKdshWgrkwg8AsDJhgKntfsPOaz b7Qsp0pV1ywkBKENXHHwLzyZJLzQc4yqh8ye/cHmNhBwebzEf7TSeahYCez7icda klScJ+uNlJ/hyV9pn1EVquW874aHlOPsgpbwJW3Nl8nSNO9uEhHIIOgezsgS1ykB UDFgfJ8v6pOGYBmQxRvsU7Vjwt4Gl8PlLLJqnLcHNCGUMkoPUwz02KDl6yZIP1dI iHD7Ldl9Z/0Q7vx9DJMw8U2LAKTOEGWEGd8AwD2f/fXqpndqQxWRlSvxpXYISF8= =y3ka -----END PGP SIGNATURE----- --CmIgqG7taeW01srPj8bi9sQsQPcsPqXqr--