From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49398)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XUbo1-0008Gt-L7
	for qemu-devel@nongnu.org; Thu, 18 Sep 2014 09:31:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XUbnv-0003BU-7C
	for qemu-devel@nongnu.org; Thu, 18 Sep 2014 09:31:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:25535)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XUbnv-00039n-0A
	for qemu-devel@nongnu.org; Thu, 18 Sep 2014 09:31:23 -0400
Message-ID: <541ADE9A.3000603@redhat.com>
Date: Thu, 18 Sep 2014 15:31:06 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1411044447-3124-1-git-send-email-arei.gonglei@huawei.com>
	<1411044447-3124-13-git-send-email-arei.gonglei@huawei.com>
	<541AD6F8.106@redhat.com>
	<33183CC9F5247A488A2544077AF1902086DD791F@SZXEMA503-MBS.china.huawei.com>
In-Reply-To: <33183CC9F5247A488A2544077AF1902086DD791F@SZXEMA503-MBS.china.huawei.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 12/19] dev-serial: convert init to
	realize
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Luonengjun <luonengjun@huawei.com>, "Huangpeng (Peter)" <peter.huangpeng@huawei.com>, "Huangweidong (C)" <weidong.huang@huawei.com>, "kraxel@redhat.com" <kraxel@redhat.com>, "armbru@redhat.com" <armbru@redhat.com>

Il 18/09/2014 15:26, Gonglei (Arei) ha scritto:
> Yes, we can. 
> 
> Can we use qerror_report_err still in realize function?
> Just report this error but not propagate to the caller. Thanks!

No, I think propagating the error is fine.  In fact I suggested checking
for the error more aggressively, so that it can better propagate to the
caller.

Paolo