From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50787)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XUbtu-0002Hy-Jt
	for qemu-devel@nongnu.org; Thu, 18 Sep 2014 09:37:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XUbtp-0004xn-I8
	for qemu-devel@nongnu.org; Thu, 18 Sep 2014 09:37:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:18871)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XUbtp-0004ws-BB
	for qemu-devel@nongnu.org; Thu, 18 Sep 2014 09:37:29 -0400
Message-ID: <541AE00A.8000606@redhat.com>
Date: Thu, 18 Sep 2014 15:37:14 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1411044447-3124-1-git-send-email-arei.gonglei@huawei.com>
	<1411044447-3124-13-git-send-email-arei.gonglei@huawei.com>
	<541AD6F8.106@redhat.com>
	<33183CC9F5247A488A2544077AF1902086DD791F@SZXEMA503-MBS.china.huawei.com>
	<541ADE9A.3000603@redhat.com>
	<33183CC9F5247A488A2544077AF1902086DD794C@SZXEMA503-MBS.china.huawei.com>
In-Reply-To: <33183CC9F5247A488A2544077AF1902086DD794C@SZXEMA503-MBS.china.huawei.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 12/19] dev-serial: convert init to
	realize
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Luonengjun <luonengjun@huawei.com>, "Huangpeng (Peter)" <peter.huangpeng@huawei.com>, "Huangweidong (C)" <weidong.huang@huawei.com>, "kraxel@redhat.com" <kraxel@redhat.com>, "armbru@redhat.com" <armbru@redhat.com>

Il 18/09/2014 15:35, Gonglei (Arei) ha scritto:
>> From: Paolo Bonzini [mailto:pbonzini@redhat.com]
>> Sent: Thursday, September 18, 2014 9:31 PM
>> To: Gonglei (Arei); qemu-devel@nongnu.org
>> Cc: kraxel@redhat.com; Huangweidong (C); armbru@redhat.com; Huangpeng
>> (Peter); Luonengjun
>> Subject: Re: [PATCH v2 12/19] dev-serial: convert init to realize
>>
>> Il 18/09/2014 15:26, Gonglei (Arei) ha scritto:
>>> Yes, we can.
>>>
>>> Can we use qerror_report_err still in realize function?
>>> Just report this error but not propagate to the caller. Thanks!
>>
>> No, I think propagating the error is fine.  In fact I suggested checking
>> for the error more aggressively, so that it can better propagate to the
>> caller.
>>
>> Paolo
> 
> OK, got it. v3 will be posted shortly. Thanks :)

No need for that.  It can be done as a separate series.  This v2 is fine
for me.

Paolo