From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUgfF-00079H-Df for qemu-devel@nongnu.org; Thu, 18 Sep 2014 14:42:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUgf6-00046O-D3 for qemu-devel@nongnu.org; Thu, 18 Sep 2014 14:42:45 -0400 Received: from mail-wg0-x234.google.com ([2a00:1450:400c:c00::234]:46464) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUgf6-00045V-6A for qemu-devel@nongnu.org; Thu, 18 Sep 2014 14:42:36 -0400 Received: by mail-wg0-f52.google.com with SMTP id x13so1317005wgg.11 for ; Thu, 18 Sep 2014 11:42:30 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <541B2790.2030705@redhat.com> Date: Thu, 18 Sep 2014 20:42:24 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1411044447-3124-1-git-send-email-arei.gonglei@huawei.com> <87a95w4zq6.fsf@blackfin.pond.sub.org> In-Reply-To: <87a95w4zq6.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 00/19] usb: convert device init to realize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , arei.gonglei@huawei.com Cc: luonengjun@huawei.com, kraxel@redhat.com, weidong.huang@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com Il 18/09/2014 19:15, Markus Armbruster ha scritto: > > Thanks for doing this work. If you can do a bit more of the same, here > are a few more device model init() methods I'd love to have converted, > because they use qerror_report_err(): > > hw/char/serial-pci.c serial_pci_init() > multi_serial_pci_init() > hw/i386/kvm/pci-assign.c assigned_initfn() Converting PCI is Gargantuan, but even something like patch 1 in this series would be nice to have. Paolo