From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58572) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUhxK-0001sq-R6 for qemu-devel@nongnu.org; Thu, 18 Sep 2014 16:05:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUhxB-0000Kp-Kv for qemu-devel@nongnu.org; Thu, 18 Sep 2014 16:05:30 -0400 Received: from mail-ie0-x22e.google.com ([2607:f8b0:4001:c03::22e]:51944) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUhxB-0000IY-GH for qemu-devel@nongnu.org; Thu, 18 Sep 2014 16:05:21 -0400 Received: by mail-ie0-f174.google.com with SMTP id y20so2092917ier.19 for ; Thu, 18 Sep 2014 13:05:15 -0700 (PDT) Message-ID: <541B3AF1.1090606@gmail.com> Date: Thu, 18 Sep 2014 15:05:05 -0500 From: Tom Musta MIME-Version: 1.0 References: <1410793421-6453-1-git-send-email-pbonzini@redhat.com> <1410793421-6453-11-git-send-email-pbonzini@redhat.com> In-Reply-To: <1410793421-6453-11-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/14] ppc: use movcond for isel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: agraf@suse.de On 9/15/2014 10:03 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > v1->v2: fixed TCG debugging failures > > target-ppc/translate.c | 26 +++++++++++++------------- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/target-ppc/translate.c b/target-ppc/translate.c > index 9ff8763..0933c00 100644 > --- a/target-ppc/translate.c > +++ b/target-ppc/translate.c > @@ -777,27 +777,27 @@ static void gen_cmpli(DisasContext *ctx) > /* isel (PowerPC 2.03 specification) */ > static void gen_isel(DisasContext *ctx) > { > - int l1, l2; > uint32_t bi = rC(ctx->opcode); > uint32_t mask; > TCGv_i32 t0; > - > - l1 = gen_new_label(); > - l2 = gen_new_label(); > + TCGv t1, true_op, zero; > > mask = 0x08 >> (bi & 0x03); > t0 = tcg_temp_new_i32(); > tcg_gen_andi_i32(t0, cpu_crf[bi >> 2], mask); > - tcg_gen_brcondi_i32(TCG_COND_EQ, t0, 0, l1); > - if (rA(ctx->opcode) == 0) > - tcg_gen_movi_tl(cpu_gpr[rD(ctx->opcode)], 0); > - else > - tcg_gen_mov_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rA(ctx->opcode)]); > - tcg_gen_br(l2); > - gen_set_label(l1); > - tcg_gen_mov_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rB(ctx->opcode)]); > - gen_set_label(l2); > + t1 = tcg_temp_new(); > + tcg_gen_extu_i32_tl(t1, t0); > + zero = tcg_const_tl(0); > + if (rA(ctx->opcode) == 0) { > + true_op = zero; > + } else { > + true_op = cpu_gpr[rA(ctx->opcode)]; > + } > + tcg_gen_movcond_tl(TCG_COND_NE, cpu_gpr[rD(ctx->opcode)], t1, zero, > + true_op, cpu_gpr[rB(ctx->opcode)]); > + tcg_temp_free(t1); > tcg_temp_free_i32(t0); > + tcg_temp_free(zero); > } > > /* cmpb: PowerPC 2.05 specification */ > Reviewed-by: Tom Musta Tested-by: Tom Musta