From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52666)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XUtEp-0007Jd-CO
	for qemu-devel@nongnu.org; Fri, 19 Sep 2014 04:08:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XUtEj-0000f3-V7
	for qemu-devel@nongnu.org; Fri, 19 Sep 2014 04:08:19 -0400
Received: from mail-wi0-x22e.google.com ([2a00:1450:400c:c05::22e]:52780)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XUtEj-0000eT-PB
	for qemu-devel@nongnu.org; Fri, 19 Sep 2014 04:08:13 -0400
Received: by mail-wi0-f174.google.com with SMTP id n3so4415964wiv.13
	for <qemu-devel@nongnu.org>; Fri, 19 Sep 2014 01:08:08 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <541BE462.70309@redhat.com>
Date: Fri, 19 Sep 2014 10:08:02 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1411111521-12540-1-git-send-email-arei.gonglei@huawei.com>
In-Reply-To: <1411111521-12540-1-git-send-email-arei.gonglei@huawei.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/2] usb-serial: only check speed once at
	realize time
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: arei.gonglei@huawei.com, qemu-devel@nongnu.org
Cc: luonengjun@huawei.com, kraxel@redhat.com, weidong.huang@huawei.com, peter.huangpeng@huawei.com, armbru@redhat.com

Il 19/09/2014 09:25, arei.gonglei@huawei.com ha scritto:
> From: Gonglei <arei.gonglei@huawei.com>
> 
> This patch series based on 
>  [PATCH v3 00/19] usb: convert device init to realize
> 
> As Paolo's comments:
> 
> usb port speed check could be extracted to a separate
> function usb_check_attach, that is called just once at realize time,
> even if !s->cs->be_open.
> 
> Please review, Thanks. :)
> 
> Gonglei (2):
>   usb-bus: introduce a wrapper function to check speed
>   usb-serial: only check speed once at realize time
> 
>  hw/usb/bus.c        | 14 +++++++++++++-
>  hw/usb/dev-serial.c | 16 +++++++++-------
>  include/hw/usb.h    |  1 +
>  3 files changed, 23 insertions(+), 8 deletions(-)
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>