From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUtGN-0008WC-Iw for qemu-devel@nongnu.org; Fri, 19 Sep 2014 04:10:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUtGI-0000yo-4K for qemu-devel@nongnu.org; Fri, 19 Sep 2014 04:09:55 -0400 Sender: Paolo Bonzini Message-ID: <541BE4B8.3010609@redhat.com> Date: Fri, 19 Sep 2014 10:09:28 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1411097848-3900-1-git-send-email-zhang.zhanghailiang@huawei.com> In-Reply-To: <1411097848-3900-1-git-send-email-zhang.zhanghailiang@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1] vl: Fix possible freed memory accessing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, luonengjun@huawei.com, peter.huangpeng@huawei.com Il 19/09/2014 05:37, zhanghailiang ha scritto: > The logic of pcmcia_socket_unregister is wrong, > which will cause a freed memory accessing > > Signed-off-by: zhanghailiang > --- > Hi, > > The function pcmcia_socket_unregister seemes to be unused, > Should it be removed? Thanks. Perhaps---however, the patch silences a Coverity warning, so it is worthwhile. Thanks for doing this! Reviewed-by: Paolo Bonzini Paolo