From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50863) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUxkl-0005Qq-0T for qemu-devel@nongnu.org; Fri, 19 Sep 2014 08:57:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUxkb-0005DE-VU for qemu-devel@nongnu.org; Fri, 19 Sep 2014 08:57:34 -0400 Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:47629) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUxkb-000569-OF for qemu-devel@nongnu.org; Fri, 19 Sep 2014 08:57:25 -0400 Received: by mail-wi0-f176.google.com with SMTP id ex7so4832841wid.15 for ; Fri, 19 Sep 2014 05:57:19 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <541C2829.5020704@redhat.com> Date: Fri, 19 Sep 2014 14:57:13 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1411116849-18157-1-git-send-email-pbonzini@redhat.com> <1411116849-18157-2-git-send-email-pbonzini@redhat.com> <541BF4B9.9060708@intel.com> In-Reply-To: <541BF4B9.9060708@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] serial: reset state at startup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Chen, Tiejun" , qemu-devel@nongnu.org Cc: armbru@redhat.com, pavel.dovgaluk@ispras.ru, batuzovk@ispras.ru Il 19/09/2014 11:17, Chen, Tiejun ha scritto: > On 2014/9/19 16:54, Paolo Bonzini wrote: >> When a serial port is started, its initial state is all zero. Make >> it consistent with reset state instead. >> >> Signed-off-by: Paolo Bonzini >> --- >> hw/char/serial.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/hw/char/serial.c b/hw/char/serial.c >> index 764e184..4523ccb 100644 >> --- a/hw/char/serial.c >> +++ b/hw/char/serial.c >> @@ -668,6 +668,7 @@ void serial_realize_core(SerialState *s, Error >> **errp) >> serial_event, s); > > It should just follow qemu_register_reset(serial_reset, s). > >> fifo8_create(&s->recv_fifo, UART_FIFO_LENGTH); >> fifo8_create(&s->xmit_fifo, UART_FIFO_LENGTH); >> + serial_reset(s); > > Or at least we should push this before this pair of fifo8_create() since No, it should be _after_ the fifo8_create() pair. With the current implementation it doesn't matter, but first you create something and then you initialize it, not the other way round. Paolo > static void serial_reset(void *opaque) > { > ... > fifo8_reset(&s->recv_fifo); > fifo8_reset(&s->xmit_fifo); > > > Thanks > Tiejun > >> } >> >> void serial_exit_core(SerialState *s) >> > >