From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33647) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUyaz-0008Ug-En for qemu-devel@nongnu.org; Fri, 19 Sep 2014 09:51:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUyat-00023v-A0 for qemu-devel@nongnu.org; Fri, 19 Sep 2014 09:51:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3132) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUyat-00022Q-1X for qemu-devel@nongnu.org; Fri, 19 Sep 2014 09:51:27 -0400 Message-ID: <541C34D2.6030402@redhat.com> Date: Fri, 19 Sep 2014 15:51:14 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1410793421-6453-1-git-send-email-pbonzini@redhat.com> <1410793421-6453-14-git-send-email-pbonzini@redhat.com> <541B41A5.70202@gmail.com> In-Reply-To: <541B41A5.70202@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 13/14] ppc: inline ppc_set_crf when clearer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tom Musta , qemu-devel@nongnu.org Cc: agraf@suse.de Il 18/09/2014 22:33, Tom Musta ha scritto: >> > Do not go through the loop when we're setting the four CR fields to >> > separate constants or conditions. This is clearer than putting together >> > 4-bit value and passing it. > I guess "clearer" is in the eye of the beholder .... :) > > In general, replacing a single line of code with four is not a simplification (IMO). > > That said, I was not able to spot or identify by testing any functional problems with this patch. > True. It is better to say that it avoids messing with bit endianness. Paolo