From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46626)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XUzXn-0005jw-Qe
	for qemu-devel@nongnu.org; Fri, 19 Sep 2014 10:52:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XUzXe-0001Lg-39
	for qemu-devel@nongnu.org; Fri, 19 Sep 2014 10:52:19 -0400
Received: from mail-wg0-x234.google.com ([2a00:1450:400c:c00::234]:61998)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XUzXd-0001GQ-Tf
	for qemu-devel@nongnu.org; Fri, 19 Sep 2014 10:52:10 -0400
Received: by mail-wg0-f52.google.com with SMTP id x13so2520598wgg.35
	for <qemu-devel@nongnu.org>; Fri, 19 Sep 2014 07:52:04 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <541C4310.5050405@redhat.com>
Date: Fri, 19 Sep 2014 16:52:00 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1410793421-6453-1-git-send-email-pbonzini@redhat.com>
	<1410793421-6453-10-git-send-email-pbonzini@redhat.com>
	<541B37CB.5010902@gmail.com>
In-Reply-To: <541B37CB.5010902@gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 09/14] ppc: introduce ppc_get_crf and
	ppc_set_crf
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tom Musta <tommusta@gmail.com>, qemu-devel@nongnu.org
Cc: agraf@suse.de

Il 18/09/2014 21:51, Tom Musta ha scritto:
> 
> Checkpatch fails:
> WARNING: braces {} are necessary for all arms of this statement
> #171: FILE: target-ppc/translate.c:11111:
> +        if (ppc_get_crf(env, i) & 0x08)
> [...]
> -        else if (env->crf[i] & 0x04)
> [...]
>              a = 'G';
> [...]
> 
> WARNING: braces {} are necessary for all arms of this statement
> #174: FILE: target-ppc/translate.c:11113:
> +        else if (ppc_get_crf(env, i) & 0x04)
> [...]
> -        else if (env->crf[i] & 0x02)
> [...]
> 
> WARNING: braces {} are necessary for all arms of this statement
> #177: FILE: target-ppc/translate.c:11115:
> +        else if (ppc_get_crf(env, i) & 0x02)
> [...]
> 
> total: 0 errors, 3 warnings, 131 lines checked
> 

This goes away with patch 14, so I made the intermediate patch lighter
by omitting the code-style cleanups.

Paolo