From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53801) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XV07a-0006Tb-RM for qemu-devel@nongnu.org; Fri, 19 Sep 2014 11:29:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XV07U-0001fS-MA for qemu-devel@nongnu.org; Fri, 19 Sep 2014 11:29:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18394) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XV07U-0001dR-Cf for qemu-devel@nongnu.org; Fri, 19 Sep 2014 11:29:12 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8JFT6Xr032375 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 19 Sep 2014 11:29:06 -0400 Message-ID: <541C4BBB.1060802@redhat.com> Date: Fri, 19 Sep 2014 11:28:59 -0400 From: John Snow MIME-Version: 1.0 References: <1411083819-9284-1-git-send-email-jsnow@redhat.com> <87k34znaot.fsf@blackfin.pond.sub.org> In-Reply-To: <87k34znaot.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 00/15] AHCI test helper refactors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com On 09/19/2014 06:53 AM, Markus Armbruster wrote: > John Snow writes: > >> The original version of the AHCI test base >> which is now staged for being merged, processes >> the ahci_identify test in a monolithic fashion. >> >> In authoring new tests, it became necessary and >> obvious as to how the operation of this device >> should be factored out to ease the writing of >> new AHCI tests. >> >> This patch set issues the necessary refactorings >> to support future test development for AHCI. >> >> This patch set DOES NOT account for any new fixes >> and requires no fixes from my "AHCI fixes" RFC >> in order to run successfully on 2014-09-18's >> origin/master. >> >> This patch set does not alter the operation of the >> existing test, or add new tests. It only offers >> refactorings for future patch submissions which >> depend on them, but are still under consideration. > [...] >> tests/ahci-test.c | 860 ++++++++++++++++++++++++++++++++++++--------= ---------- >> 1 file changed, 583 insertions(+), 277 deletions(-) > > Ignorant question: why should we commit the "monolithic" test only to > refactor it extensively right away? > Newbie problems, basically. I submitted the first AHCI test series 2014-07-07. The tests were staged=20 last week. A lot happened on my downstream copy in that time, but I=20 opted to keep the series "the same scope" from v1 through v4, because=20 otherwise the series would have just kept growing ... I submitted v4 I do apologize at how absurd it is, on your end, to see an introduction=20 followed immediately by a refactor. It seemed like the idea at the time=20 was to get a basis that people agreed upon, then modify as needed. Sorry for the confusion. --=20 =97js