qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Auger <eric.auger@linaro.org>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: peter.maydell@linaro.org, kim.phillips@freescale.com,
	eric.auger@st.com, a.rigo@virtualopensystems.com, aik@ozlabs.ru,
	patches@linaro.org, agraf@suse.de, qemu-devel@nongnu.org,
	Bharat.Bhushan@freescale.com, bsd@redhat.com,
	alex.williamson@redhat.com, kraxel@redhat.com,
	stuart.yoder@freescale.com, pbonzini@redhat.com,
	kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org
Subject: Re: [Qemu-devel] [RFC] vfio: migration to trace points
Date: Fri, 19 Sep 2014 18:07:02 +0200	[thread overview]
Message-ID: <541C54A6.5080506@linaro.org> (raw)
In-Reply-To: <20140919090331.GA27501@stefanha-thinkpad.redhat.com>

Hi Stefan,

Thanks for asking. Actually I think this is a bit early. I would like
some VFIO PCI users experiencing it a little bit (typically Alex) and
confirm they are happy with it.

Also as I mentionned in the commit message, I identified some parsing
issues that forced me to change few format strings. I don't know if you
have time or are willing to fix those - you may be more efficient doing
those fixes than I would;-) - Nethertheless if you can't afford, I will
have a look at the Python code.

For convenience I put the issues again, all related to parenthesis:

Cases than are not correctly handled are given below:
- "(%04x:%02x:%02x.%x)" need to be replaced by " (%04x:%02x:%02x.%x)"
- "%s read(%04x:%02x:%02x.%x:BAR%d+0x%"PRIx64", %d) = 0x%"PRIx64 replaced by
  "%s read(%04x:%02x:%02x.%x:BAR%d+0x%"PRIx64", %d = 0x%"PRIx64
- "%s write(%04x:%02x:%02x.%x:BAR%d+0x%"PRIx64", 0x%"PRIx64", %d)"
replaced by
  "%s write(%04x:%02x:%02x.%x:BAR%d+0x%"PRIx64", 0x%"PRIx64", %d"

Best Regards

Eric




On 09/19/2014 11:03 AM, Stefan Hajnoczi wrote:
> On Wed, Sep 03, 2014 at 09:45:14AM +0100, Eric Auger wrote:
>> This patch removes all DPRINTF and replace them by trace points.
>> A few DPRINTF used in error cases were transformed into error_report.
>>
>> Signed-off-by: Eric Auger <eric.auger@linaro.org>
> 
> The subject line says "RFC".  Are you proposing this patch for merge?
> 
> Did you want me to take it into the tracing tree?
> 
> Stefan
> 

  reply	other threads:[~2014-09-19 16:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-03  8:45 [Qemu-devel] [RFC] vfio: migration to trace points Eric Auger
2014-09-03  9:13 ` Alexander Graf
2014-09-18 23:30 ` Eric Auger
2014-09-19  9:03 ` Stefan Hajnoczi
2014-09-19 16:07   ` Eric Auger [this message]
2014-09-19 20:40     ` Alexander Graf
2014-09-22 16:15     ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=541C54A6.5080506@linaro.org \
    --to=eric.auger@linaro.org \
    --cc=Bharat.Bhushan@freescale.com \
    --cc=a.rigo@virtualopensystems.com \
    --cc=agraf@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=alex.williamson@redhat.com \
    --cc=bsd@redhat.com \
    --cc=christoffer.dall@linaro.org \
    --cc=eric.auger@st.com \
    --cc=kim.phillips@freescale.com \
    --cc=kraxel@redhat.com \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=patches@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=stuart.yoder@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).