From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35073) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XV0ir-0004Gk-Vv for qemu-devel@nongnu.org; Fri, 19 Sep 2014 12:07:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XV0im-0003eT-1l for qemu-devel@nongnu.org; Fri, 19 Sep 2014 12:07:49 -0400 Received: from mail-pd0-f169.google.com ([209.85.192.169]:61774) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XV0il-0003dp-S6 for qemu-devel@nongnu.org; Fri, 19 Sep 2014 12:07:43 -0400 Received: by mail-pd0-f169.google.com with SMTP id w10so212329pde.14 for ; Fri, 19 Sep 2014 09:07:37 -0700 (PDT) Message-ID: <541C54A6.5080506@linaro.org> Date: Fri, 19 Sep 2014 18:07:02 +0200 From: Eric Auger MIME-Version: 1.0 References: <1409733914-1272-1-git-send-email-eric.auger@linaro.org> <20140919090331.GA27501@stefanha-thinkpad.redhat.com> In-Reply-To: <20140919090331.GA27501@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC] vfio: migration to trace points List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: peter.maydell@linaro.org, kim.phillips@freescale.com, eric.auger@st.com, a.rigo@virtualopensystems.com, aik@ozlabs.ru, patches@linaro.org, agraf@suse.de, qemu-devel@nongnu.org, Bharat.Bhushan@freescale.com, bsd@redhat.com, alex.williamson@redhat.com, kraxel@redhat.com, stuart.yoder@freescale.com, pbonzini@redhat.com, kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org Hi Stefan, Thanks for asking. Actually I think this is a bit early. I would like some VFIO PCI users experiencing it a little bit (typically Alex) and confirm they are happy with it. Also as I mentionned in the commit message, I identified some parsing issues that forced me to change few format strings. I don't know if you have time or are willing to fix those - you may be more efficient doing those fixes than I would;-) - Nethertheless if you can't afford, I will have a look at the Python code. For convenience I put the issues again, all related to parenthesis: Cases than are not correctly handled are given below: - "(%04x:%02x:%02x.%x)" need to be replaced by " (%04x:%02x:%02x.%x)" - "%s read(%04x:%02x:%02x.%x:BAR%d+0x%"PRIx64", %d) = 0x%"PRIx64 replaced by "%s read(%04x:%02x:%02x.%x:BAR%d+0x%"PRIx64", %d = 0x%"PRIx64 - "%s write(%04x:%02x:%02x.%x:BAR%d+0x%"PRIx64", 0x%"PRIx64", %d)" replaced by "%s write(%04x:%02x:%02x.%x:BAR%d+0x%"PRIx64", 0x%"PRIx64", %d" Best Regards Eric On 09/19/2014 11:03 AM, Stefan Hajnoczi wrote: > On Wed, Sep 03, 2014 at 09:45:14AM +0100, Eric Auger wrote: >> This patch removes all DPRINTF and replace them by trace points. >> A few DPRINTF used in error cases were transformed into error_report. >> >> Signed-off-by: Eric Auger > > The subject line says "RFC". Are you proposing this patch for merge? > > Did you want me to take it into the tracing tree? > > Stefan >