From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51411) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XV7az-000804-06 for qemu-devel@nongnu.org; Fri, 19 Sep 2014 19:28:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XV7au-0001iE-Tt for qemu-devel@nongnu.org; Fri, 19 Sep 2014 19:28:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6384) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XV7au-0001gs-MR for qemu-devel@nongnu.org; Fri, 19 Sep 2014 19:28:04 -0400 Message-ID: <541CBBF3.90008@redhat.com> Date: Fri, 19 Sep 2014 17:27:47 -0600 From: Eric Blake MIME-Version: 1.0 References: <1411163937-19891-1-git-send-email-minyard@acm.org> In-Reply-To: <1411163937-19891-1-git-send-email-minyard@acm.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="23JGNhwuilFf3H6IJcFroTiDNP7tmNcLA" Subject: Re: [Qemu-devel] [PATCH] chardev: Add reconnecting to client sockets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: minyard@acm.org, qemu-devel@nongnu.org Cc: mjg59@srcf.ucam.org, mst@redhat.com, hwd@huawei.com, bcketchum@gmail.com, Corey Minyard , afaerber@suse.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --23JGNhwuilFf3H6IJcFroTiDNP7tmNcLA Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/19/2014 03:58 PM, minyard@acm.org wrote: > From: Corey Minyard >=20 > Adds a "recon" option to socket backends that gives a reconnect > timeout. This only applies to client sockets. If the other end > of a socket closes the connection, qemu will attempt to reconnect > after the given number of seconds. >=20 > This rearranges things a bit, all socket configuration is moved to > qmp_chardev_open_socket() and that only gets called once at startup. > qemu_chr_open_socket_fd() is called to open or re-open the connection. >=20 > Signed-off-by: Corey Minyard > --- > qapi-schema.json | 6 +- > qemu-char.c | 209 +++++++++++++++++++++++++++++++++++++++++------= -------- > qemu-options.hx | 20 ++++-- > 3 files changed, 174 insertions(+), 61 deletions(-) >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index 689b548..f42562f 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -2648,6 +2648,9 @@ > # @nodelay: #optional set TCP_NODELAY socket option (default: false) > # @telnet: #optional enable telnet protocol on server > # sockets (default: false) > +# @recon: #optional If not a server socket, if the socket disconnect > +# then reconnect after the given number of seconds. Setting > +# to zero disables this function. (default: 0) "recon" makes me think of spy novels, not reconnect. Any reason you can't name it something more descriptive, like "reconnect-time"? Missing a "since 2.2" designation. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --23JGNhwuilFf3H6IJcFroTiDNP7tmNcLA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUHLvzAAoJEKeha0olJ0Nqtd8IAJQ2FkMXv9k5b70EdGevwSE0 4CkV+i0gOVNwB3vAk5DeH/EhEB6gZUZcWjXx4jbzFpWLIIdDZvgA9S/6uIQiKNv8 s44EHXcH2XxzLY37+D1zvP8JKH5JXljtYTtdzRSHMgD8ZSO8HBqDEVR9TrQQxJ57 SBq//zx1VepdWCHjknF/3pydEjbJFlnHNPn5L9y6RxRYZHnAtMeKoZFB63XnQiFk DNX0RY/DpdhXphXypODo5PakQ1hpUyYkI0SPIRe7F+cD94UNRCCY6UJ1cXGhV9nN APr3F4/BCZ/SQ4+eSMceXU1fB+UUWtnJ6Ga1LotimacnHGOLNpHsflaO9RupdYY= =t1kC -----END PGP SIGNATURE----- --23JGNhwuilFf3H6IJcFroTiDNP7tmNcLA--