From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43380) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XVyh4-0005Zp-Bk for qemu-devel@nongnu.org; Mon, 22 Sep 2014 04:10:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XVygv-0005QR-B0 for qemu-devel@nongnu.org; Mon, 22 Sep 2014 04:09:58 -0400 Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:40237) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XVygu-0005Oy-Tq for qemu-devel@nongnu.org; Mon, 22 Sep 2014 04:09:49 -0400 Received: by mail-wg0-f42.google.com with SMTP id a1so2284480wgh.25 for ; Mon, 22 Sep 2014 01:09:43 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <541FD947.2080302@redhat.com> Date: Mon, 22 Sep 2014 10:09:43 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1407303308-4615-1-git-send-email-famz@redhat.com> <1407303308-4615-10-git-send-email-famz@redhat.com> <541BF77C.3090808@redhat.com> <20140922055607.GA19858@fam-t430.nay.redhat.com> In-Reply-To: <20140922055607.GA19858@fam-t430.nay.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v2 09/10] virtio-scsi-dataplane: Code to run virtio-scsi on iothread List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com Il 22/09/2014 07:56, Fam Zheng ha scritto: >> > >> > Please add these to VirtIOSCSI rather than VirtIOSCSICommon. Same for >> > the new functions you declare below. > What's the rationale, please? Asking because especially the VirtIOSCSIVring > fields are the dataplane counterparts of VirtQueue fields, so putting in > VirtIOSCSI seems unnatural for me. Because everything you put in VirtIOSCSICommon will be shared between virtio-scsi and vhost-scsi, and vhost-scsi need not use neither vring nor dataplane. Paolo