From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37118) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XVzi5-0001FS-Jb for qemu-devel@nongnu.org; Mon, 22 Sep 2014 05:15:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XVzhw-0001u3-Ir for qemu-devel@nongnu.org; Mon, 22 Sep 2014 05:15:05 -0400 Received: from mail-wi0-x22a.google.com ([2a00:1450:400c:c05::22a]:57240) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XVzhw-0001rz-Bw for qemu-devel@nongnu.org; Mon, 22 Sep 2014 05:14:56 -0400 Received: by mail-wi0-f170.google.com with SMTP id fb4so2430629wid.5 for ; Mon, 22 Sep 2014 02:14:50 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <541FE889.3050209@redhat.com> Date: Mon, 22 Sep 2014 11:14:49 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1410792279-2488-1-git-send-email-arei.gonglei@huawei.com> <20140922083421.GA13006@redhat.com> In-Reply-To: <20140922083421.GA13006@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , arei.gonglei@huawei.com Cc: weidong.huang@huawei.com, aliguori@amazon.com, qemu-devel@nongnu.org, agraf@suse.de, stefanha@redhat.com, peter.huangpeng@huawei.com, lcapitulino@redhat.com Il 22/09/2014 10:34, Michael S. Tsirkin ha scritto: > Basically this patch brings back historical HMP behaviour. > As far as I could tell, it wasn't changed intentionally. It was changed intentionally. Or rather, the change was known at the time Stefan made it. > So how about applying this first and then making more > changes on top if required? No. There is no reason to add alias-specific fields to ObjectProperty, and the implementation is not even complete because you can alias property X of object A to property Y of object B. Paolo