From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XVzjY-0002cK-2K for qemu-devel@nongnu.org; Mon, 22 Sep 2014 05:16:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XVzjS-0002Iq-48 for qemu-devel@nongnu.org; Mon, 22 Sep 2014 05:16:36 -0400 Received: from mail-we0-x22d.google.com ([2a00:1450:400c:c03::22d]:40040) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XVzjR-0002IH-Tj for qemu-devel@nongnu.org; Mon, 22 Sep 2014 05:16:30 -0400 Received: by mail-we0-f173.google.com with SMTP id x48so1105543wes.18 for ; Mon, 22 Sep 2014 02:16:24 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <541FE8E8.9000804@redhat.com> Date: Mon, 22 Sep 2014 11:16:24 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1410530338-17615-1-git-send-email-pbonzini@redhat.com> <1410530338-17615-14-git-send-email-pbonzini@redhat.com> <30501.4520571151$1411123417@news.gmane.org> <541C1BBE.6090808@redhat.com> <000401cfd408$3f6208d0$be261a70$@Dovgaluk@ispras.ru> <541C328D.9020808@redhat.com> <8379.85978364504$1411374220@news.gmane.org> In-Reply-To: <8379.85978364504$1411374220@news.gmane.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 13/21] apic_common: vapic_paddr synchronization fix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgaluk , qemu-devel@nongnu.org Il 22/09/2014 10:21, Pavel Dovgaluk ha scritto: > >> -----Original Message----- >> From: Paolo Bonzini [mailto:pbonzini@redhat.com] >> Sent: Friday, September 19, 2014 5:42 PM >> To: Pavel Dovgaluk; qemu-devel@nongnu.org >> Subject: Re: [PULL 13/21] apic_common: vapic_paddr synchronization fix >> >> Il 19/09/2014 14:50, Pavel Dovgaluk ha scritto: >>> vapic_paddr depends on cpu_number. cpu_number cannot be retrieved when do_vapic_enable >> executes. >>> Thus we cannot reconstruct vapic_paddr in that function. >> >> cpu_number will always be zero, because do_vapic_enable is only executed >> for smp_cpus == 1. > > Right. Here it is: This patch was already applied. Please make a new patch on top of current master, and send it with your Signed-off-by. Paolo