* [Qemu-devel] [PATCH] file-posix: fix request_alignment typo
@ 2019-08-27 10:13 Stefan Hajnoczi
2019-08-27 10:15 ` Thomas Huth
2019-08-27 17:24 ` Max Reitz
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2019-08-27 10:13 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, qemu-trivial, Stefan Hajnoczi, qemu-block, Max Reitz
Fixes: a6b257a08e3d72219f03e461a52152672fec0612
("file-posix: Handle undetectable alignment")
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
block/file-posix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/file-posix.c b/block/file-posix.c
index fbeb0068db..67abd1f01c 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -380,7 +380,7 @@ static void raw_probe_alignment(BlockDriverState *bs, int fd, Error **errp)
for (i = 0; i < ARRAY_SIZE(alignments); i++) {
align = alignments[i];
if (raw_is_io_aligned(fd, buf + align, max_align)) {
- /* Fallback to request_aligment. */
+ /* Fallback to request_alignment. */
s->buf_align = (align != 1) ? align : bs->bl.request_alignment;
break;
}
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] file-posix: fix request_alignment typo
2019-08-27 10:13 [Qemu-devel] [PATCH] file-posix: fix request_alignment typo Stefan Hajnoczi
@ 2019-08-27 10:15 ` Thomas Huth
2019-08-27 17:24 ` Max Reitz
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2019-08-27 10:15 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel
Cc: Kevin Wolf, qemu-trivial, qemu-block, Max Reitz
On 27/08/2019 12.13, Stefan Hajnoczi wrote:
> Fixes: a6b257a08e3d72219f03e461a52152672fec0612
> ("file-posix: Handle undetectable alignment")
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> block/file-posix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/file-posix.c b/block/file-posix.c
> index fbeb0068db..67abd1f01c 100644
> --- a/block/file-posix.c
> +++ b/block/file-posix.c
> @@ -380,7 +380,7 @@ static void raw_probe_alignment(BlockDriverState *bs, int fd, Error **errp)
> for (i = 0; i < ARRAY_SIZE(alignments); i++) {
> align = alignments[i];
> if (raw_is_io_aligned(fd, buf + align, max_align)) {
> - /* Fallback to request_aligment. */
> + /* Fallback to request_alignment. */
> s->buf_align = (align != 1) ? align : bs->bl.request_alignment;
> break;
> }
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] file-posix: fix request_alignment typo
2019-08-27 10:13 [Qemu-devel] [PATCH] file-posix: fix request_alignment typo Stefan Hajnoczi
2019-08-27 10:15 ` Thomas Huth
@ 2019-08-27 17:24 ` Max Reitz
1 sibling, 0 replies; 3+ messages in thread
From: Max Reitz @ 2019-08-27 17:24 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel; +Cc: Kevin Wolf, qemu-trivial, qemu-block
[-- Attachment #1.1: Type: text/plain, Size: 402 bytes --]
On 27.08.19 12:13, Stefan Hajnoczi wrote:
> Fixes: a6b257a08e3d72219f03e461a52152672fec0612
> ("file-posix: Handle undetectable alignment")
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> block/file-posix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-27 17:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-27 10:13 [Qemu-devel] [PATCH] file-posix: fix request_alignment typo Stefan Hajnoczi
2019-08-27 10:15 ` Thomas Huth
2019-08-27 17:24 ` Max Reitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).