From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53947) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW2OO-0002RZ-8P for qemu-devel@nongnu.org; Mon, 22 Sep 2014 08:07:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XW2OE-0006KW-SF for qemu-devel@nongnu.org; Mon, 22 Sep 2014 08:06:56 -0400 Received: from mail-we0-x235.google.com ([2a00:1450:400c:c03::235]:37888) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW2OE-0006KE-KB for qemu-devel@nongnu.org; Mon, 22 Sep 2014 08:06:46 -0400 Received: by mail-we0-f181.google.com with SMTP id w61so920139wes.12 for ; Mon, 22 Sep 2014 05:06:40 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <542010CE.3010209@redhat.com> Date: Mon, 22 Sep 2014 14:06:38 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1410792279-2488-1-git-send-email-arei.gonglei@huawei.com> <20140922083421.GA13006@redhat.com> <541FE889.3050209@redhat.com> <33183CC9F5247A488A2544077AF1902086DD90B3@SZXEMA503-MBS.china.huawei.com> <541FF3F9.5060705@redhat.com> <33183CC9F5247A488A2544077AF1902086DD915A@SZXEMA503-MBS.china.huawei.com> In-Reply-To: <33183CC9F5247A488A2544077AF1902086DD915A@SZXEMA503-MBS.china.huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gonglei (Arei)" , "Michael S. Tsirkin" Cc: "Huangweidong (C)" , "aliguori@amazon.com" , "qemu-devel@nongnu.org" , "agraf@suse.de" , "stefanha@redhat.com" , "Huangpeng (Peter)" , "lcapitulino@redhat.com" Il 22/09/2014 13:22, Gonglei (Arei) ha scritto: > > This doesn't change the fact that ObjectProperty is a generic struct, > > and adding alias-specific fields there is wrong. > > OK, Maybe I should find other ways to attach this purpose and > avoid layering violation. Thanks! Unfortunately I cannot think of any. We could add a description field to ObjectProperty, and replace legacy_name with a description. The output then would be virtio-blk.drive=str (drive) That's a bit hackish, but perhaps it would be good enough for mst and Markus? Paolo