qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4] vmdk: Fix integer overflow in offset calculation
Date: Mon, 22 Sep 2014 13:40:21 +0100	[thread overview]
Message-ID: <542018B5.2030509@ilande.co.uk> (raw)
In-Reply-To: <1411370144-536-1-git-send-email-famz@redhat.com>

On 22/09/14 08:15, Fam Zheng wrote:

> This fixes the bug introduced by commit c6ac36e (vmdk: Optimize cluster
> allocation).
>
> $ ~/build/master/qemu-io /stor/vm/arch.vmdk -c 'write 2G 1k'
> write failed: Invalid argument
>
> Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Signed-off-by: Fam Zheng <famz@redhat.com>

Unfortunately I don't have access to the VMWare system anymore (it 
belongs to a client) but I can at least confirm that applying your v4 
patch to git master allows me to complete the original conversion 
process without throwing an error at the 2GB limit.


Many thanks,

Mark.

      parent reply	other threads:[~2014-09-22 12:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-22  7:15 [Qemu-devel] [PATCH v4] vmdk: Fix integer overflow in offset calculation Fam Zheng
2014-09-22  9:56 ` Stefan Hajnoczi
2014-09-22 12:32 ` Max Reitz
2014-09-23  1:54   ` Fam Zheng
2014-09-22 12:40 ` Mark Cave-Ayland [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=542018B5.2030509@ilande.co.uk \
    --to=mark.cave-ayland@ilande.co.uk \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).