From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW2vC-0004ev-Sp for qemu-devel@nongnu.org; Mon, 22 Sep 2014 08:40:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XW2v6-0000pY-M9 for qemu-devel@nongnu.org; Mon, 22 Sep 2014 08:40:50 -0400 Received: from s16892447.onlinehome-server.info ([82.165.15.123]:55169) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW2v6-0000oc-G8 for qemu-devel@nongnu.org; Mon, 22 Sep 2014 08:40:44 -0400 Received: from [86.188.254.49] (helo=[172.30.1.185]) by s16892447.onlinehome-server.info with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1XW2uu-0006lb-3a for qemu-devel@nongnu.org; Mon, 22 Sep 2014 13:40:32 +0100 Message-ID: <542018B5.2030509@ilande.co.uk> Date: Mon, 22 Sep 2014 13:40:21 +0100 From: Mark Cave-Ayland MIME-Version: 1.0 References: <1411370144-536-1-git-send-email-famz@redhat.com> In-Reply-To: <1411370144-536-1-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4] vmdk: Fix integer overflow in offset calculation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 22/09/14 08:15, Fam Zheng wrote: > This fixes the bug introduced by commit c6ac36e (vmdk: Optimize cluster > allocation). > > $ ~/build/master/qemu-io /stor/vm/arch.vmdk -c 'write 2G 1k' > write failed: Invalid argument > > Reported-by: Mark Cave-Ayland > Signed-off-by: Fam Zheng Unfortunately I don't have access to the VMWare system anymore (it belongs to a client) but I can at least confirm that applying your v4 patch to git master allows me to complete the original conversion process without throwing an error at the 2GB limit. Many thanks, Mark.