From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW3hI-0001eo-8d for qemu-devel@nongnu.org; Mon, 22 Sep 2014 09:30:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XW3h9-0006wg-6P for qemu-devel@nongnu.org; Mon, 22 Sep 2014 09:30:32 -0400 Received: from mail-wi0-x22b.google.com ([2a00:1450:400c:c05::22b]:33187) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW3ca-0005Xy-0b for qemu-devel@nongnu.org; Mon, 22 Sep 2014 09:25:40 -0400 Received: by mail-wi0-f171.google.com with SMTP id ho1so2916752wib.4 for ; Mon, 22 Sep 2014 06:25:34 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5420234D.7000505@redhat.com> Date: Mon, 22 Sep 2014 15:25:33 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1411340664-26912-1-git-send-email-minyard@acm.org> <1411340664-26912-5-git-send-email-minyard@acm.org> <541FD872.8000601@redhat.com> <542020F7.5050906@acm.org> In-Reply-To: <542020F7.5050906@acm.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/6] qemu-char: set socket filename to disconnected when not connected List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: minyard@acm.org, qemu-devel@nongnu.org Cc: mjg59@srcf.ucam.org, Corey Minyard , hwd@huawei.com, bcketchum@gmail.com, mst@redhat.com, afaerber@suse.de Il 22/09/2014 15:15, Corey Minyard ha scritto: >> > Why move this from qemu_chr_finish_socket_connection to tcp_chr_connect? >> > Perhaps move this part of the patch earlier, either just before or just >> > after patch 2? > I had to make this change, otherwise a server socket would never show > that it reconnected. I originally hadn't moved it. Reconnected or connected? How does reconnection work with server sockets? I guess you can then move it to patch 2. Paolo