From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53552) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW3dT-0006S3-Ro for qemu-devel@nongnu.org; Mon, 22 Sep 2014 09:26:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XW3dK-0005iJ-3N for qemu-devel@nongnu.org; Mon, 22 Sep 2014 09:26:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8194) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW3dJ-0005gl-RH for qemu-devel@nongnu.org; Mon, 22 Sep 2014 09:26:26 -0400 Message-ID: <54202375.6060003@redhat.com> Date: Mon, 22 Sep 2014 15:26:13 +0200 From: Max Reitz MIME-Version: 1.0 References: <1410891148-28849-1-git-send-email-armbru@redhat.com> <1410891148-28849-22-git-send-email-armbru@redhat.com> In-Reply-To: <1410891148-28849-22-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 21/23] blockdev: Convert qmp_eject(), qmp_change_blockdev() to BlockBackend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, benoit.canet@nodalink.com, stefanha@redhat.com On 16.09.2014 20:12, Markus Armbruster wrote: > Much more command code needs conversion. I'm converting these now > because they's using bdrv_dev_* functions, which I'm about to lift Either this is again some phrase I haven't yet picked up or it should be "they're". ;-) > into BlockBackend. > > Signed-off-by: Markus Armbruster > --- > blockdev.c | 20 ++++++++++++-------- > 1 file changed, 12 insertions(+), 8 deletions(-) With that fixed (or alternatively another Wikipedia or Wiktionary reference): Reviewed-by: Max Reitz